From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ECF5E6EC5B; Tue, 30 Mar 2021 22:59:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ECF5E6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617134347; bh=bglAdv0dLyWuaHW0MggBRCRC1gk1dS6cuwOnXGlA+xQ=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=swO74mHSjBg+hZlpfCA5UVizTlit4Fxz1Ggkl5k4sMLf4uO10rUa0KyRKImLl0iYt 6hhONHoRVubWR8/9iyZzRnJ7pASJcIRau6EDXCfoumKomW+HalghnN4iP/kOAxjmJ9 DhKJa6LT4EoEBqv5+SrC9i3sMCvj8aKYS9VROM9Q= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2A15C6EC5B for ; Tue, 30 Mar 2021 22:59:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2A15C6EC5B Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1lRKW0-0006sY-LU; Tue, 30 Mar 2021 22:59:05 +0300 To: Cyrill Gorcunov Cc: tml References: <20210327111310.37504-1-gorcunov@gmail.com> <20210327111310.37504-3-gorcunov@gmail.com> <5195a08c-aaa7-7aa4-8324-352a9433955f@tarantool.org> Message-ID: <99a52a18-3a81-8fb7-0ca8-af5195822631@tarantool.org> Date: Tue, 30 Mar 2021 21:59:03 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4ABD7C98AF5DBFD37182A05F53808504004BCE73F7A1984A7A933855081DD642EC0F811566168FB0DD6ABD3E1D4F6229A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B264C8851FD8E810EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D7F1BE85E7B0CA818638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF9F689AD75987BDBBF5BD86A9120AABE5A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE78A0F7C24A37A3D769FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3AEB4DDBFD72C8FA1117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFA607D462841869D1BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6357748AADE45CB2976E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249B372FE9A2E580EFC725E5C173C3A84C309A7649CC036878F35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824AC8B6CDF511875BC4E8F7B195E1C978318827A5997596097DE7218EB9B50BAE8A X-C1DE0DAB: 0D63561A33F958A564B7B814E58EB90147D7066CCA4AE46CD5D4498820D1CD05D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473457D764E1CDE77FFCC38DB7AF7F5AE37F82ACE0CEC8CC9A24D237D7CE474964AC9C76F08B15BF01D7E09C32AA3244CB81DC502F51C74B99E76E349BA0A85A7408A6A02710B7304729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfQIxm2xDGobgbQ2TTlwbew== X-Mailru-Sender: D32ACFD6CDCF91C1CE0FF6C34B5952E6E1646F370EEF8356BADBDA2318188958B953E569AED4F6AC841FB911095AA09146E8006E22572C39C920B61C43410E8717BDA556287159EE9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v6 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 30.03.2021 09:19, Cyrill Gorcunov via Tarantool-patches wrote: > On Tue, Mar 30, 2021 at 12:56:47AM +0200, Vladislav Shpilevoy wrote: >>> >>> Wait, I just don't understand. is_paused is a boolean type and >>> I compare it with a boolean value. Could you simply point me >>> the preferred way to compare if some particular value is false. >>> I used assert() 'cause I found similar code, if there some more >>> suiatble way to test the value, sure thing I can use whatever >>> you prefer, just point me an example. >> >> Ok, I open the latest replication test we added (gh-5536), and >> I see the line >> >> assert(box.space.test:count() == 10) >> >> It does not look like this: >> >> assert((box.space.test:count() == 10) == true) >> >> does it? Because it is pointless to have 'boolean' type in a > > This is because the count() is a numeric value. What had been > there if 'count()' would return a boolean? I don't see how it is related to count() being numeric. I am talking about 'count() == 10', not about the 'count()' itself. That expression is boolean, and therefore is supposed to be used with boolean operators.