From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF. Date: Wed, 10 May 2023 15:34:57 +0300 [thread overview] Message-ID: <cover.1683720396.git.skaplun@tarantool.org> (raw) The backported commit needs to be checked precisely -- we don't want to just check that the assertion failures are gone -- some commits [1] may replace the aforementioned assertions with `return 0` or something else [2] due to other issues. Hence, we need to be sure that there is no such IR as "NEWREF.*-0" for these traces anymore. So the first commit introduces new utility module for tests to parse traces dumped into the file. There is nothing too fancy -- for now, the returned traces may only say is there some particular IR or no. Any other features may be added in the future uses, if we need. Q: Can we use `jit.dump()` as is, without temporary file? A: Yes, but no: `jit.dump()` may be easily patched to use a custom object as the second argument, not only file name. But this module dumps trace information not by lines but more iterative. So we can use the similar approach as in <luajit-gdb.py> -- concat each line and only then dump it. But I don't ready to discuss this opportunity with Mike now:). So, for now just use a temporary file and remove it after usage. Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-noticket-folding-0 Taranrool PR: https://github.com/tarantool/tarantool/pull/8634 Related issues: * https://github.com/tarantool/tarantool/issues/8516 * https://github.com/LuaJIT/LuaJIT/issues/981 [1]: https://github.com/LuaJIT/LuaJIT/commit/d4c0c6e17ef7edf1f2893bc807746b80612e63e9 [2]: https://github.com/LuaJIT/LuaJIT/issues/994 Mike Pall (1): Fix canonicalization of +-0.0 keys for IR_NEWREF. Sergey Kaplun (1): test: add utility for parsing `jit.dump` src/lj_record.c | 2 + .../tarantool-tests/lj-981-folding-0.test.lua | 57 +++++++ test/tarantool-tests/utils/jit_parse.lua | 156 ++++++++++++++++++ 3 files changed, 215 insertions(+) create mode 100644 test/tarantool-tests/lj-981-folding-0.test.lua create mode 100644 test/tarantool-tests/utils/jit_parse.lua -- 2.34.1
next reply other threads:[~2023-05-10 12:39 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-10 12:34 Sergey Kaplun via Tarantool-patches [this message] 2023-05-10 12:34 ` [Tarantool-patches] [PATCH luajit 1/2] test: add utility for parsing `jit.dump` Sergey Kaplun via Tarantool-patches 2023-05-15 11:11 ` Maxim Kokryashkin via Tarantool-patches 2023-05-15 12:00 ` Maxim Kokryashkin via Tarantool-patches 2023-05-21 7:47 ` Sergey Kaplun via Tarantool-patches 2023-05-21 7:39 ` Sergey Kaplun via Tarantool-patches 2023-05-22 7:04 ` Sergey Kaplun via Tarantool-patches 2023-05-29 13:55 ` Maxim Kokryashkin via Tarantool-patches 2023-05-16 10:55 ` Sergey Bronnikov via Tarantool-patches 2023-05-22 7:02 ` Sergey Kaplun via Tarantool-patches 2023-05-22 9:14 ` Sergey Kaplun via Tarantool-patches 2023-05-10 12:34 ` [Tarantool-patches] [PATCH luajit 2/2] Fix canonicalization of +-0.0 keys for IR_NEWREF Sergey Kaplun via Tarantool-patches 2023-05-15 12:05 ` Maxim Kokryashkin via Tarantool-patches 2023-05-20 15:03 ` Sergey Kaplun via Tarantool-patches 2023-05-16 12:17 ` Sergey Bronnikov via Tarantool-patches 2023-05-20 14:54 ` Sergey Kaplun via Tarantool-patches 2023-05-22 7:55 ` Sergey Bronnikov via Tarantool-patches 2023-06-27 13:28 ` [Tarantool-patches] [PATCH luajit 1/3] test: split utils.lua into several modules Igor Munkin via Tarantool-patches 2023-06-27 13:35 ` Igor Munkin via Tarantool-patches 2023-06-28 11:36 ` Sergey Kaplun via Tarantool-patches 2023-06-28 16:07 ` Igor Munkin via Tarantool-patches 2023-07-04 17:10 ` [Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1683720396.git.skaplun@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox