From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9713B440F5B; Wed, 10 May 2023 15:39:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9713B440F5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1683722344; bh=l/L9DfRKrsb3dkKrcmNM0Nr1RT+0D2iBNPO0OEGT2dY=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=i9fEejf1sllozbqPubwiPFKZiLoDTvYCTbDL67pYQvkuMLAUlnBtgehC6HB+X8lbd 773dDQANKwnUYW2r7ifU07D8ddxfWEIxKPpCEf1WikOoxs6gARqJU0O91ePGXPHKUO 8+NXz3OQDZZj5ObLFoB59xJa9nmYB/77PJirNp+s= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E0AA7254C7F for ; Wed, 10 May 2023 15:39:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E0AA7254C7F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pwj5x-0007mJ-IJ; Wed, 10 May 2023 15:39:02 +0300 To: Maxim Kokryashkin , Sergey Bronnikov Date: Wed, 10 May 2023 15:34:57 +0300 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9EB47717F7D295292D67C76A64B1B07133F10B2F7B0DD9258182A05F538085040D76DCDB568562571AA4BAADD59607ED8E86634B66AC1C3CCE3F78F08705949CF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A548C5E803E75135EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779018AFA06A12C538638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8398B60F73B3B21F4646AEC093DD84CE4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC0E6D796F508274C4A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C24E1E72F37C03A02CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6B1CFA6D474D4A6A4089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5E9B67909D5751EC69AF4754A0BA323D8B4445C2A65D9C08FF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B359C5DF10A05D560A950611B66E3DA6D700B0A020F03D25A0997E3FB2386030E77 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742DC8270968E61249B1004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D345CB6DE26F16546675F8C62FA457D511B69B7230EDAF13A746F1394A0F9649C34962C43592240E3CD1D7E09C32AA3244C147BF259ACB5A92098B86CF7D7AB4930B4DF56057A86259F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbL9S8ysBdXgVndfLascvsT3wgcvSgHLE X-DA7885C5: 620FCA4FBD2A709D427A1874C5770931B157814FE9EFC016287DBE7718C79CB6262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF55D5B621CC4E3E5D1D467FB683F5F7BA90FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: [Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" The backported commit needs to be checked precisely -- we don't want to just check that the assertion failures are gone -- some commits [1] may replace the aforementioned assertions with `return 0` or something else [2] due to other issues. Hence, we need to be sure that there is no such IR as "NEWREF.*-0" for these traces anymore. So the first commit introduces new utility module for tests to parse traces dumped into the file. There is nothing too fancy -- for now, the returned traces may only say is there some particular IR or no. Any other features may be added in the future uses, if we need. Q: Can we use `jit.dump()` as is, without temporary file? A: Yes, but no: `jit.dump()` may be easily patched to use a custom object as the second argument, not only file name. But this module dumps trace information not by lines but more iterative. So we can use the similar approach as in -- concat each line and only then dump it. But I don't ready to discuss this opportunity with Mike now:). So, for now just use a temporary file and remove it after usage. Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-noticket-folding-0 Taranrool PR: https://github.com/tarantool/tarantool/pull/8634 Related issues: * https://github.com/tarantool/tarantool/issues/8516 * https://github.com/LuaJIT/LuaJIT/issues/981 [1]: https://github.com/LuaJIT/LuaJIT/commit/d4c0c6e17ef7edf1f2893bc807746b80612e63e9 [2]: https://github.com/LuaJIT/LuaJIT/issues/994 Mike Pall (1): Fix canonicalization of +-0.0 keys for IR_NEWREF. Sergey Kaplun (1): test: add utility for parsing `jit.dump` src/lj_record.c | 2 + .../tarantool-tests/lj-981-folding-0.test.lua | 57 +++++++ test/tarantool-tests/utils/jit_parse.lua | 156 ++++++++++++++++++ 3 files changed, 215 insertions(+) create mode 100644 test/tarantool-tests/lj-981-folding-0.test.lua create mode 100644 test/tarantool-tests/utils/jit_parse.lua -- 2.34.1