From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Fix canonicalization of +-0.0 keys for IR_NEWREF.
Date: Mon, 22 May 2023 10:55:59 +0300 [thread overview]
Message-ID: <9de714d8-e444-27ee-7d07-b3c24a94be2a@tarantool.org> (raw)
In-Reply-To: <ZGjfNAwW7fTYY9yp@root>
Hi, Sergey!
LGTM now.
On 5/20/23 17:54, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Please consider my comments below.
>
> On 16.05.23, Sergey Bronnikov wrote:
>> Hello, Sergey!
>>
>> Thanks for the patch! To be honest I'm not proficient enough
>>
>> for reviewing such patches, but I don't have objections, only a couple
>
next prev parent reply other threads:[~2023-05-22 7:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 12:34 [Tarantool-patches] [PATCH luajit 0/2] " Sergey Kaplun via Tarantool-patches
2023-05-10 12:34 ` [Tarantool-patches] [PATCH luajit 1/2] test: add utility for parsing `jit.dump` Sergey Kaplun via Tarantool-patches
2023-05-15 11:11 ` Maxim Kokryashkin via Tarantool-patches
2023-05-15 12:00 ` Maxim Kokryashkin via Tarantool-patches
2023-05-21 7:47 ` Sergey Kaplun via Tarantool-patches
2023-05-21 7:39 ` Sergey Kaplun via Tarantool-patches
2023-05-22 7:04 ` Sergey Kaplun via Tarantool-patches
2023-05-29 13:55 ` Maxim Kokryashkin via Tarantool-patches
2023-05-16 10:55 ` Sergey Bronnikov via Tarantool-patches
2023-05-22 7:02 ` Sergey Kaplun via Tarantool-patches
2023-05-22 9:14 ` Sergey Kaplun via Tarantool-patches
2023-05-10 12:34 ` [Tarantool-patches] [PATCH luajit 2/2] Fix canonicalization of +-0.0 keys for IR_NEWREF Sergey Kaplun via Tarantool-patches
2023-05-15 12:05 ` Maxim Kokryashkin via Tarantool-patches
2023-05-20 15:03 ` Sergey Kaplun via Tarantool-patches
2023-05-16 12:17 ` Sergey Bronnikov via Tarantool-patches
2023-05-20 14:54 ` Sergey Kaplun via Tarantool-patches
2023-05-22 7:55 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-06-27 13:28 ` [Tarantool-patches] [PATCH luajit 1/3] test: split utils.lua into several modules Igor Munkin via Tarantool-patches
2023-06-27 13:35 ` Igor Munkin via Tarantool-patches
2023-06-28 11:36 ` Sergey Kaplun via Tarantool-patches
2023-06-28 16:07 ` Igor Munkin via Tarantool-patches
2023-07-04 17:10 ` [Tarantool-patches] [PATCH luajit 0/2] Fix canonicalization of +-0.0 keys for IR_NEWREF Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de714d8-e444-27ee-7d07-b3c24a94be2a@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/2] Fix canonicalization of +-0.0 keys for IR_NEWREF.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox