Re: [Tarantool-patches] [PATCH v4 1/3] gc/xlog: delay xlog cleanup until relays are subscribed

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On 25.03.2021 22:29, Cyrill Gorcunov wrote:
> On Fri, Mar 26, 2021 at 12:02:56AM +0300, Cyrill Gorcunov wrote:
>>
>> then it passed into C level as 0x7fffffffffffffff
>> which is NaN in ieee-754.
>>
>> 2021-03-25 23:53:45.588 [2068763] main/103/interactive I> set 'wal_cleanup_delay' configuration option to inf
> 
> I changed the code to
> 
> static double
> box_check_wal_cleanup_delay(void)
> {
> 	double value = cfg_getd("wal_cleanup_delay");
> 	if (isfinite(value) == 0 && value >= 0) {
> 		diag_set(ClientError, ER_CFG, "wal_cleanup_delay",
> 			 "value must be finite and >= 0");
> 		return -1;
> 	}
> 
> 	return value;
> }
> 
>  | tarantool> box.cfg{wal_cleanup_delay = math.huge}
>  | ---
>  | - error: 'Incorrect value for option ''wal_cleanup_delay'': value must be finite and
>  |     >= 0'
>  | ...
> 

You don't need to change it to finite if it works fine being infinite.
I only wanted to have a test that it does not crash somewhere on that.

If it would crash, it would mean we would need to fix the other timeouts
too. Otherwise your timeout still is inconsistent with them if you ban
the literal infinity.