From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 36C996F3C7; Fri, 26 Mar 2021 02:50:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 36C996F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616716247; bh=kSBSoAFl6E0DjyS9v5oolKYGG0J/Q6CN2dlMi7tSrDw=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ynEy3penf/uQFtSaBgqd1k32ZS5Oko9wMO7wQldUxYuENGdzUs5p2ij5dbI7phT8J t56yz9lmdT24R+GUsXj8KABgcD8CTMNQr3BVysD5bldbuhN4dTT5X+Ff7Aoh8D2Ut7 2OXznUDz3ppQKx5aXs+954ht735LEBLv10bCH908= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A607A6F3C7 for ; Fri, 26 Mar 2021 02:50:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A607A6F3C7 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lPZkP-0002iv-K4; Fri, 26 Mar 2021 02:50:42 +0300 To: Cyrill Gorcunov References: <20210324163759.1900553-1-gorcunov@gmail.com> <20210324163759.1900553-2-gorcunov@gmail.com> <8faa2e1e-c198-832d-d527-1acf2280720d@tarantool.org> <19605c5e-e96c-8580-6309-3b0e58df8c01@tarantool.org> Message-ID: Date: Fri, 26 Mar 2021 00:50:40 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE922675D89A18E042B1EBC993A8274C79D182A05F538085040DCE1E02E48596E1F6C3CFBBA29A4D49A17371E11C4F0B75A85AA6CA8FA0935BC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76DA79C5AFF329FDBEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D438B07A5F5221A91083E8B53DAC9970CA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7ECE82AE7387CF2AD9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8273DE7764599A117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831D0198C5286BC332F77A8C5B82A5066A9 X-C1DE0DAB: 0D63561A33F958A5AA253FC3ECBD187155343411D40B9CD59C5F0A801BD855B0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F7CC4EA888783AE0061CAC2A28283850315FA01AC552F6487ACA20A4C3794E35078D865C571E78F61D7E09C32AA3244CFA627EA3303E186D1BAA2FF525D3E6F27101BF96129E4011FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAgxIZoD1QnBsQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638224114A16C36FC724FCD5F6923E8FB4FA83841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 1/3] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 25.03.2021 22:29, Cyrill Gorcunov wrote: > On Fri, Mar 26, 2021 at 12:02:56AM +0300, Cyrill Gorcunov wrote: >> >> then it passed into C level as 0x7fffffffffffffff >> which is NaN in ieee-754. >> >> 2021-03-25 23:53:45.588 [2068763] main/103/interactive I> set 'wal_cleanup_delay' configuration option to inf > > I changed the code to > > static double > box_check_wal_cleanup_delay(void) > { > double value = cfg_getd("wal_cleanup_delay"); > if (isfinite(value) == 0 && value >= 0) { > diag_set(ClientError, ER_CFG, "wal_cleanup_delay", > "value must be finite and >= 0"); > return -1; > } > > return value; > } > > | tarantool> box.cfg{wal_cleanup_delay = math.huge} > | --- > | - error: 'Incorrect value for option ''wal_cleanup_delay'': value must be finite and > | >= 0' > | ... > You don't need to change it to finite if it works fine being infinite. I only wanted to have a test that it does not crash somewhere on that. If it would crash, it would mean we would need to fix the other timeouts too. Otherwise your timeout still is inconsistent with them if you ban the literal infinity.