From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 1/3] gc/xlog: delay xlog cleanup until relays are subscribed
Date: Fri, 26 Mar 2021 00:29:59 +0300 [thread overview]
Message-ID: <YF0A1wVTFucyFrfV@grain> (raw)
In-Reply-To: <YFz6gCp9voLmQOAV@grain>
On Fri, Mar 26, 2021 at 12:02:56AM +0300, Cyrill Gorcunov wrote:
>
> then it passed into C level as 0x7fffffffffffffff
> which is NaN in ieee-754.
>
> 2021-03-25 23:53:45.588 [2068763] main/103/interactive I> set 'wal_cleanup_delay' configuration option to inf
I changed the code to
static double
box_check_wal_cleanup_delay(void)
{
double value = cfg_getd("wal_cleanup_delay");
if (isfinite(value) == 0 && value >= 0) {
diag_set(ClientError, ER_CFG, "wal_cleanup_delay",
"value must be finite and >= 0");
return -1;
}
return value;
}
| tarantool> box.cfg{wal_cleanup_delay = math.huge}
| ---
| - error: 'Incorrect value for option ''wal_cleanup_delay'': value must be finite and
| >= 0'
| ...
next prev parent reply other threads:[~2021-03-25 21:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 16:37 [Tarantool-patches] [PATCH v4 0/3] " Cyrill Gorcunov via Tarantool-patches
2021-03-24 16:37 ` [Tarantool-patches] [PATCH v4 1/3] " Cyrill Gorcunov via Tarantool-patches
2021-03-24 22:10 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-25 11:25 ` Cyrill Gorcunov via Tarantool-patches
2021-03-25 19:59 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-25 21:02 ` Cyrill Gorcunov via Tarantool-patches
2021-03-25 21:29 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-03-25 23:50 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-26 7:04 ` Cyrill Gorcunov via Tarantool-patches
2021-03-25 23:51 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-26 7:04 ` Cyrill Gorcunov via Tarantool-patches
2021-03-24 16:37 ` [Tarantool-patches] [PATCH v4 2/3] test: add a test for wal_cleanup_delay option Cyrill Gorcunov via Tarantool-patches
2021-03-24 22:10 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-25 12:07 ` Cyrill Gorcunov via Tarantool-patches
2021-03-25 19:56 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-25 20:19 ` Cyrill Gorcunov via Tarantool-patches
2021-03-24 16:37 ` [Tarantool-patches] [PATCH v4 3/3] test: box-tap/gc -- add test for is_paused field Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF0A1wVTFucyFrfV@grain \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 1/3] gc/xlog: delay xlog cleanup until relays are subscribed' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox