Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off
@ 2021-01-13 14:42 Sergey Bronnikov via Tarantool-patches
  2021-01-13 17:03 ` Vladislav Shpilevoy via Tarantool-patches
  2021-01-14 12:54 ` Kirill Yukhin via Tarantool-patches
  0 siblings, 2 replies; 4+ messages in thread
From: Sergey Bronnikov via Tarantool-patches @ 2021-01-13 14:42 UTC (permalink / raw)
  To: tarantool-patches, v.shpilevoy

From: Sergey Bronnikov <sergeyb@tarantool.org>

Closes #5467

Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Reviewed-by: Igor Munkin <imun@tarantool.org>

Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Co-authored-by: Igor Munkin <imun@tarantool.org>
---
Issue: https://github.com/tarantool/tarantool/issues/5467
Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/241108325

 .luacheckrc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.luacheckrc b/.luacheckrc
index 4b829f3dc..638131e4a 100644
--- a/.luacheckrc
+++ b/.luacheckrc
@@ -45,7 +45,7 @@ exclude_files = {
     "test/swim/**/*.lua",
     "test/var/**/*.lua",
     "test/vinyl/**/*.lua",
-    "test/wal_off/**/*.lua",
+    "test/wal_off/*.test.lua",
     "test/xlog/**/*.lua",
     "test/xlog-py/**/*.lua",
     "third_party/**/*.lua",
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off
  2021-01-13 14:42 [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off Sergey Bronnikov via Tarantool-patches
@ 2021-01-13 17:03 ` Vladislav Shpilevoy via Tarantool-patches
  2021-01-14  7:50   ` Sergey Bronnikov via Tarantool-patches
  2021-01-14 12:54 ` Kirill Yukhin via Tarantool-patches
  1 sibling, 1 reply; 4+ messages in thread
From: Vladislav Shpilevoy via Tarantool-patches @ 2021-01-13 17:03 UTC (permalink / raw)
  To: sergeyb, tarantool-patches

Thanks for the patch!

LGTM if it works.

On 13.01.2021 15:42, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #5467
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
> Issue: https://github.com/tarantool/tarantool/issues/5467
> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/241108325

What is the branch name?

>  .luacheckrc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index 4b829f3dc..638131e4a 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -45,7 +45,7 @@ exclude_files = {
>      "test/swim/**/*.lua",
>      "test/var/**/*.lua",
>      "test/vinyl/**/*.lua",
> -    "test/wal_off/**/*.lua",
> +    "test/wal_off/*.test.lua",
>      "test/xlog/**/*.lua",
>      "test/xlog-py/**/*.lua",
>      "third_party/**/*.lua",
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off
  2021-01-13 17:03 ` Vladislav Shpilevoy via Tarantool-patches
@ 2021-01-14  7:50   ` Sergey Bronnikov via Tarantool-patches
  0 siblings, 0 replies; 4+ messages in thread
From: Sergey Bronnikov via Tarantool-patches @ 2021-01-14  7:50 UTC (permalink / raw)
  To: Vladislav Shpilevoy, tarantool-patches

Thanks for review!

On 13.01.2021 20:03, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> LGTM if it works.
>
> On 13.01.2021 15:42, sergeyb@tarantool.org wrote:
>> From: Sergey Bronnikov <sergeyb@tarantool.org>
>>
>> Closes #5467
>>
>> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
>> Reviewed-by: Igor Munkin <imun@tarantool.org>
>>
>> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
>> Co-authored-by: Igor Munkin <imun@tarantool.org>
>> ---
>> Issue: https://github.com/tarantool/tarantool/issues/5467
>> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/241108325
> What is the branch name?
ligurio/gh-5467-luacheck-warnings-test-wal_off
>
>>   .luacheckrc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.luacheckrc b/.luacheckrc
>> index 4b829f3dc..638131e4a 100644
>> --- a/.luacheckrc
>> +++ b/.luacheckrc
>> @@ -45,7 +45,7 @@ exclude_files = {
>>       "test/swim/**/*.lua",
>>       "test/var/**/*.lua",
>>       "test/vinyl/**/*.lua",
>> -    "test/wal_off/**/*.lua",
>> +    "test/wal_off/*.test.lua",
>>       "test/xlog/**/*.lua",
>>       "test/xlog-py/**/*.lua",
>>       "third_party/**/*.lua",
>>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off
  2021-01-13 14:42 [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off Sergey Bronnikov via Tarantool-patches
  2021-01-13 17:03 ` Vladislav Shpilevoy via Tarantool-patches
@ 2021-01-14 12:54 ` Kirill Yukhin via Tarantool-patches
  1 sibling, 0 replies; 4+ messages in thread
From: Kirill Yukhin via Tarantool-patches @ 2021-01-14 12:54 UTC (permalink / raw)
  To: sergeyb; +Cc: tarantool-patches, v.shpilevoy

Hello,

On 13 янв 17:42, Sergey Bronnikov via Tarantool-patches wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #5467
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
> Issue: https://github.com/tarantool/tarantool/issues/5467
> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/241108325

I've checked your patch into 2.6, 2.7 and master.

--
Regards, Kirill Yukhin

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-14 12:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 14:42 [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off Sergey Bronnikov via Tarantool-patches
2021-01-13 17:03 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-14  7:50   ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:54 ` Kirill Yukhin via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox