From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off Date: Thu, 14 Jan 2021 10:50:50 +0300 [thread overview] Message-ID: <bc6a13de-f0b0-d8d5-a981-0a9bcc57f54b@tarantool.org> (raw) In-Reply-To: <292b7f8b-0d4e-a258-dbc8-981386b8a299@tarantool.org> Thanks for review! On 13.01.2021 20:03, Vladislav Shpilevoy wrote: > Thanks for the patch! > > LGTM if it works. > > On 13.01.2021 15:42, sergeyb@tarantool.org wrote: >> From: Sergey Bronnikov <sergeyb@tarantool.org> >> >> Closes #5467 >> >> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> >> Reviewed-by: Igor Munkin <imun@tarantool.org> >> >> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> >> Co-authored-by: Igor Munkin <imun@tarantool.org> >> --- >> Issue: https://github.com/tarantool/tarantool/issues/5467 >> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/241108325 > What is the branch name? ligurio/gh-5467-luacheck-warnings-test-wal_off > >> .luacheckrc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.luacheckrc b/.luacheckrc >> index 4b829f3dc..638131e4a 100644 >> --- a/.luacheckrc >> +++ b/.luacheckrc >> @@ -45,7 +45,7 @@ exclude_files = { >> "test/swim/**/*.lua", >> "test/var/**/*.lua", >> "test/vinyl/**/*.lua", >> - "test/wal_off/**/*.lua", >> + "test/wal_off/*.test.lua", >> "test/xlog/**/*.lua", >> "test/xlog-py/**/*.lua", >> "third_party/**/*.lua", >>
next prev parent reply other threads:[~2021-01-14 7:50 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-13 14:42 Sergey Bronnikov via Tarantool-patches 2021-01-13 17:03 ` Vladislav Shpilevoy via Tarantool-patches 2021-01-14 7:50 ` Sergey Bronnikov via Tarantool-patches [this message] 2021-01-14 12:54 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bc6a13de-f0b0-d8d5-a981-0a9bcc57f54b@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/wal_off' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox