From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] dbg: introduce lj-ctype command, extend cdata dump
Date: Tue, 30 Jun 2026 17:53:22 +0300 [thread overview]
Message-ID: <bc0c9f74-3fbc-48e8-841f-fb93fd30f271@tarantool.org> (raw)
In-Reply-To: <20260625202903.3157425-3-skaplun@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
Hi, Sergey,
thanks for the patch! LGTM with minor comments.
Sergey
On 6/25/26 23:29, Sergey Kaplun wrote:
<snipped>
> +
> +
> +def ctype_repr(cts, id):
> + ctype = ctype_get(cts, id)
> + ctypestr = ''
> + qual = 0
> + ptrto = 0
> + while True:
probably it should be somehow limited, with broken memory/coredump
the loop may be an infinite
<snipped>
> test_cls.test = lambda self: self.check()
>
[-- Attachment #2: Type: text/html, Size: 1260 bytes --]
next prev parent reply other threads:[~2026-06-30 14:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 20:29 [Tarantool-patches] [PATCH luajit 0/3] Extend debug extension Sergey Kaplun via Tarantool-patches
2026-06-25 20:29 ` [Tarantool-patches] [PATCH luajit 1/3] dbg: introduce lj-ir, lj-jslots, lj-trace dumpers Sergey Kaplun via Tarantool-patches
2026-06-28 1:03 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-28 16:32 ` Sergey Kaplun via Tarantool-patches
2026-06-29 16:35 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-30 14:45 ` Sergey Bronnikov via Tarantool-patches
2026-06-30 16:01 ` Sergey Kaplun via Tarantool-patches
2026-07-01 11:23 ` Sergey Bronnikov via Tarantool-patches
2026-06-25 20:29 ` [Tarantool-patches] [PATCH luajit 2/3] dbg: introduce lj-ctype command, extend cdata dump Sergey Kaplun via Tarantool-patches
2026-06-29 13:55 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-29 19:20 ` Sergey Kaplun via Tarantool-patches
2026-06-30 11:48 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-30 12:27 ` Sergey Kaplun via Tarantool-patches
2026-06-30 13:07 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-30 14:03 ` Sergey Kaplun via Tarantool-patches
2026-06-30 15:07 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-30 14:53 ` Sergey Bronnikov via Tarantool-patches [this message]
2026-06-30 15:03 ` Sergey Kaplun via Tarantool-patches
2026-07-01 8:25 ` Sergey Kaplun via Tarantool-patches
2026-07-01 11:20 ` Sergey Bronnikov via Tarantool-patches
2026-06-25 20:29 ` [Tarantool-patches] [PATCH luajit 3/3] test: add verbose mode for debug extension tests Sergey Kaplun via Tarantool-patches
2026-06-28 1:31 ` Evgeniy Temirgaleev via Tarantool-patches
2026-06-28 15:19 ` Sergey Kaplun via Tarantool-patches
2026-06-30 14:54 ` Sergey Bronnikov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0c9f74-3fbc-48e8-841f-fb93fd30f271@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=e.temirgaleev@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/3] dbg: introduce lj-ctype command, extend cdata dump' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox