Re: [Tarantool-patches] [PATCH luajit 3/3] test: add verbose mode for debug extension tests

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1790 bytes --]

Hi, Sergey,

thanks for the patch! LGTM

Sergey

On 6/25/26 23:29, Sergey Kaplun wrote:
> If the environment variable `DUBUGGER_TEST_VERBOSE` is set, each test
> prints the generated command and its output and doesn't delete the files
> generated for it.
> ---
>   test/tarantool-debugger-tests/debug-extension-tests.py | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
> index fc5d2c7b..adb83e1e 100644
> --- a/test/tarantool-debugger-tests/debug-extension-tests.py
> +++ b/test/tarantool-debugger-tests/debug-extension-tests.py
> @@ -43,6 +43,8 @@ else:
>       # Don't run any initialization scripts.
>       RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command']
>   
> +TEST_VERBOSE = os.getenv('DUBUGGER_TEST_VERBOSE', default=False)
> +
>   RX_ADDR = r'0x[a-f0-9]+'
>   RX_HASH = RX_ADDR  # The same pattern for hexademic values.
>   RX_BCN = r'00\d\d'
> @@ -52,7 +54,7 @@ RX_IRREF = r'0x\d\d\d\d'
>   
>   
>   def persist(data):
> -    tmp = tempfile.NamedTemporaryFile(mode='w')
> +    tmp = tempfile.NamedTemporaryFile(mode='w', delete=not TEST_VERBOSE)
>       tmp.write(data)
>       tmp.flush()
>       return tmp
> @@ -149,7 +151,12 @@ class TestCaseBase(unittest.TestCase):
>               LUAJIT_BINARY,
>               script_file.name,
>           ]
> +        if TEST_VERBOSE:
> +            print('# Test name: {}'.format(cls.__name__))
> +            print('# Test command: {}'.format(' '.join(process_cmd)))
>           cls.output = execute_process(process_cmd)
> +        if TEST_VERBOSE:
> +            print('# Command output: {}'.format(cls.output))
>           cmd_file.close()
>           script_file.close()
>   

[-- Attachment #2: Type: text/html, Size: 2151 bytes --]