From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6C5796F3E3; Tue, 30 Jun 2026 17:54:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6C5796F3E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1782831246; bh=6PLvMor9GYsDIO0AHo1iAyjosEIGFNz5qIM75Sf+l8w=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=pf10XCsCqEzS+yheZFhG6PGtOy78zacmRftve5yRAbWVHJbICSe0nGWEOTmOMJ6dV Wjb0eirDb0RYxk+c8PhRfhbAvNrQWVW6p8irwJpBGLWpuZ4QXfMqVxlaEcS7KFGwaW IbpTIvG+Jn7eUa34QcGOiThrQ6jzDkQlMlNe0zEw= Received: from send279.i.mail.ru (send279.i.mail.ru [95.163.59.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A82186F3E3 for ; Tue, 30 Jun 2026 17:54:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A82186F3E3 Received: by exim-smtp-78b8b8c574-7snqg with esmtpa (envelope-from ) id 1weZqe-0000000079C-3TjT; Tue, 30 Jun 2026 17:54:05 +0300 Content-Type: multipart/alternative; boundary="------------xbO2rTbw6oZ010nSF79uPyZq" Message-ID: <53074d7a-54cd-4d93-b53e-dfca7edb64ed@tarantool.org> Date: Tue, 30 Jun 2026 17:54:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org References: <20260625202903.3157425-1-skaplun@tarantool.org> <20260625202903.3157425-4-skaplun@tarantool.org> In-Reply-To: <20260625202903.3157425-4-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F802F6E87846D5F6B110623BB5017BB38BEE36ED859D6E8500894C459B0CD1B9FA331F2BA8D50E0B91417EB218679B823CD1311D54A2989D88E4886CE3110A531E0A116AA96AFE1E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D6964C9E324ABA58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371D5B197C6EC5B4BE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2F899BA958135B4662E070BE324C7D3C4D3E132707AF247E8F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22494854413538E1713FCC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C04CF195F1528592878941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0FD819E82F1CB48997B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1CE99E4F20BAF2718B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B96390DA516BDDC3475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A50F96807715EEB65D5002B1117B3ED6963F454CD571CCCF2F484B8D70797403F6823CB91A9FED034534781492E4B8EEAD85CCBA673D36D1A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65952FE1165322B3F9BA95CB251E74035C3024C8C323AE6BB5C69499C604F3F9F30CF10646EA8A48AB2B8341EE9D5BE9A0AFE4E1BEBF5680A2A04A95AB9D17039A32E4DDAABE7CB91266536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRSZSJkMhZtM9frwy6JdbRI= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458A4B073FA7144F86ACDECE012BE5914E05B4AFC239131BBF39863FE6180C688F3645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] test: add verbose mode for debug extension tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------xbO2rTbw6oZ010nSF79uPyZq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM Sergey On 6/25/26 23:29, Sergey Kaplun wrote: > If the environment variable `DUBUGGER_TEST_VERBOSE` is set, each test > prints the generated command and its output and doesn't delete the files > generated for it. > --- > test/tarantool-debugger-tests/debug-extension-tests.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py > index fc5d2c7b..adb83e1e 100644 > --- a/test/tarantool-debugger-tests/debug-extension-tests.py > +++ b/test/tarantool-debugger-tests/debug-extension-tests.py > @@ -43,6 +43,8 @@ else: > # Don't run any initialization scripts. > RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command'] > > +TEST_VERBOSE = os.getenv('DUBUGGER_TEST_VERBOSE', default=False) > + > RX_ADDR = r'0x[a-f0-9]+' > RX_HASH = RX_ADDR # The same pattern for hexademic values. > RX_BCN = r'00\d\d' > @@ -52,7 +54,7 @@ RX_IRREF = r'0x\d\d\d\d' > > > def persist(data): > - tmp = tempfile.NamedTemporaryFile(mode='w') > + tmp = tempfile.NamedTemporaryFile(mode='w', delete=not TEST_VERBOSE) > tmp.write(data) > tmp.flush() > return tmp > @@ -149,7 +151,12 @@ class TestCaseBase(unittest.TestCase): > LUAJIT_BINARY, > script_file.name, > ] > + if TEST_VERBOSE: > + print('# Test name: {}'.format(cls.__name__)) > + print('# Test command: {}'.format(' '.join(process_cmd))) > cls.output = execute_process(process_cmd) > + if TEST_VERBOSE: > + print('# Command output: {}'.format(cls.output)) > cmd_file.close() > script_file.close() > --------------xbO2rTbw6oZ010nSF79uPyZq Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM

Sergey

On 6/25/26 23:29, Sergey Kaplun wrote:
If the environment variable `DUBUGGER_TEST_VERBOSE` is set, each test
prints the generated command and its output and doesn't delete the files
generated for it.
---
 test/tarantool-debugger-tests/debug-extension-tests.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
index fc5d2c7b..adb83e1e 100644
--- a/test/tarantool-debugger-tests/debug-extension-tests.py
+++ b/test/tarantool-debugger-tests/debug-extension-tests.py
@@ -43,6 +43,8 @@ else:
     # Don't run any initialization scripts.
     RUN_CMD_FILE = ['--batch', '--nx', '--quiet', '--command']
 
+TEST_VERBOSE = os.getenv('DUBUGGER_TEST_VERBOSE', default=False)
+
 RX_ADDR = r'0x[a-f0-9]+'
 RX_HASH = RX_ADDR  # The same pattern for hexademic values.
 RX_BCN = r'00\d\d'
@@ -52,7 +54,7 @@ RX_IRREF = r'0x\d\d\d\d'
 
 
 def persist(data):
-    tmp = tempfile.NamedTemporaryFile(mode='w')
+    tmp = tempfile.NamedTemporaryFile(mode='w', delete=not TEST_VERBOSE)
     tmp.write(data)
     tmp.flush()
     return tmp
@@ -149,7 +151,12 @@ class TestCaseBase(unittest.TestCase):
             LUAJIT_BINARY,
             script_file.name,
         ]
+        if TEST_VERBOSE:
+            print('# Test name: {}'.format(cls.__name__))
+            print('# Test command: {}'.format(' '.join(process_cmd)))
         cls.output = execute_process(process_cmd)
+        if TEST_VERBOSE:
+            print('# Command output: {}'.format(cls.output))
         cmd_file.close()
         script_file.close()
--------------xbO2rTbw6oZ010nSF79uPyZq--