From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0F29B6F179; Tue, 30 Jun 2026 17:53:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0F29B6F179 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1782831205; bh=umnIc+pDV7I6RuSFgQIqjAOLAly7CQHM5HEf+PMo3d0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Q/Jv2iesBlGGWXmjwZh36zT0WLbL5/6WzAm+U7mVKtWdY8oZW0WZaKdkPLj+gYYr+ j1NXknZLTlsYptKp2AqyzYyySAEnwmTBbO/780mBo3nD2jpOJLSA57+rRi9xFRUKoP wdnEXrai/adsT5+4XOiwy80RdJA6Hr5SimqY2DQI= Received: from send58.i.mail.ru (send58.i.mail.ru [89.221.237.153]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B5A936F179 for ; Tue, 30 Jun 2026 17:53:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B5A936F179 Received: by exim-smtp-78b8b8c574-9vm49 with esmtpa (envelope-from ) id 1weZpy-000000004JI-2yYq; Tue, 30 Jun 2026 17:53:23 +0300 Content-Type: multipart/alternative; boundary="------------sD7DmQhL30GnuhcwGD0MkqJ3" Message-ID: Date: Tue, 30 Jun 2026 17:53:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org References: <20260625202903.3157425-1-skaplun@tarantool.org> <20260625202903.3157425-3-skaplun@tarantool.org> In-Reply-To: <20260625202903.3157425-3-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9F802F6E87846D5F65E3EFA89B00A5A964C77F7E2BB5F7CCD00894C459B0CD1B97685EB46BEC7C58CD4FF92D56319F19789C65A371650132788E4886CE3110A53160237749B4E196D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F0ABDA2F087648F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375667C07923B88CEC0ED89B543599D9F71368966037EE24285EA5A03F0917F6B3F6F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6F459A8243F1D1D44CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249BA7DA9309A993B9C76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B87E8A9892B53B2763AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352686C055BC15B7FBC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5179D825FAE97CC145002B1117B3ED696FCF77DA28453E12147A99E6294EE8661823CB91A9FED034534781492E4B8EEADEF0AF71940E62277BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659F9067D986CFA3E74723DE7CB27EAB130FE7BB3A799070659B459F02E68BB3AFF2BC88A8C38006AA7B8341EE9D5BE9A0A4279DAB585CBA2F38E49A07CEF2AD88FF8D737BE90A289916536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRSZSJkMhZtMF+rGjmqZk0M= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845833E8E694839C31210B9BF4F79351F757B50B98869AB75DDED37EE3A1E5E2EBC4645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] dbg: introduce lj-ctype command, extend cdata dump X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------sD7DmQhL30GnuhcwGD0MkqJ3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM with minor comments. Sergey On 6/25/26 23:29, Sergey Kaplun wrote: > + > + > +def ctype_repr(cts, id): > + ctype = ctype_get(cts, id) > + ctypestr = '' > + qual = 0 > + ptrto = 0 > + while True: probably it should be somehow limited, with broken memory/coredump the loop may be an infinite > test_cls.test = lambda self: self.check() > --------------sD7DmQhL30GnuhcwGD0MkqJ3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM with minor comments.

Sergey

On 6/25/26 23:29, Sergey Kaplun wrote:


<snipped>

+
+
+def ctype_repr(cts, id):
+    ctype = ctype_get(cts, id)
+    ctypestr = ''
+    qual = 0
+    ptrto = 0
+    while True:

probably it should be somehow limited, with broken memory/coredump

the loop may be an infinite


    
<snipped>
     test_cls.test = lambda self: self.check()
 
--------------sD7DmQhL30GnuhcwGD0MkqJ3--