From: Vladislav Shpilevoy via Tarantool-patches <email@example.com> To: Oleg Babin <firstname.lastname@example.org>, email@example.com Subject: Re: [Tarantool-patches] [PATCH vshard 1/2] router: drop wait_connected from master discovery Date: Tue, 7 Dec 2021 00:34:35 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Hi! Thanks for the review! On 05.12.2021 18:44, Oleg Babin wrote: > Thanks for your patch. Looks reasonable. > > However I have one question. Before this patch if some > > connection was down we perform wait_connected and in some > > cases it could lead to successful reconnection. Currently we just skip > > broken connections and don't try to reconnect. > > Could it be a problem or we perform reconnection in another place? > > What will be happen if all connections will be down? All connections use reconnect_after option in netbox. Thus netbox handles reconnect. If all are down, netbox_wait_connected won't help either. So you will need to make several master discovery iterations anyway until one is found. Also before this patch netbox_wait_connected() couldn't boost successful reconnection anyhow. It was just waiting. It didn't affect the connection state. After this patch the waiting is dropped to try to talk to the disconnected nodes later on a next master discovery iteration.
next prev parent reply other threads:[~2021-12-06 23:34 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-04 0:19 [Tarantool-patches] [PATCH vshard 0/2] VShard replica backoff, part 1 Vladislav Shpilevoy via Tarantool-patches 2021-12-04 0:19 ` [Tarantool-patches] [PATCH vshard 1/2] router: drop wait_connected from master discovery Vladislav Shpilevoy via Tarantool-patches 2021-12-05 17:44 ` Oleg Babin via Tarantool-patches 2021-12-06 23:34 ` Vladislav Shpilevoy via Tarantool-patches [this message] 2021-12-07 6:49 ` Oleg Babin via Tarantool-patches 2021-12-04 0:19 ` [Tarantool-patches] [PATCH vshard 2/2] router: don't fallback RO to master right away Vladislav Shpilevoy via Tarantool-patches 2021-12-05 17:53 ` Oleg Babin via Tarantool-patches 2021-12-06 23:56 ` Vladislav Shpilevoy via Tarantool-patches 2021-12-07 6:49 ` Oleg Babin via Tarantool-patches 2021-12-07 22:38 ` [Tarantool-patches] [PATCH vshard 0/2] VShard replica backoff, part 1 Vladislav Shpilevoy via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [Tarantool-patches] [PATCH vshard 1/2] router: drop wait_connected from master discovery' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox