From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5665C6ECC0; Tue, 7 Dec 2021 02:34:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5665C6ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638833680; bh=x/DkcnVW70V4nlzc1zk+aDLVTA09gXusyoUuwSLTh2c=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wA6lsK5F6O9fcCLc9jtYvjMeO9T+80cPYYhpJjUm0TVIqkyVXhTa1WIT4QQeidE+t XS2DgCxTDh12ITUMrYC3c/tmgRH/yewVq9r0v7N9Few2A2+xukbykorZvDCqR4E3+4 kcHFXZ/AGgCV3U3sDf4/syoeJKc2RGSfFzgfdBNU= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2FC8C6ECC0 for ; Tue, 7 Dec 2021 02:34:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FC8C6ECC0 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1muNVE-0001qb-FB; Tue, 07 Dec 2021 02:34:36 +0300 Message-ID: Date: Tue, 7 Dec 2021 00:34:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Content-Language: en-US To: Oleg Babin , tarantool-patches@dev.tarantool.org References: <3274e75ae8fc8a996645991aa2f663a72319aa1f.1638577114.git.v.shpilevoy@tarantool.org> <61db4417-1dc2-a31a-e3e7-4e4d4d10c8ee@tarantool.org> In-Reply-To: <61db4417-1dc2-a31a-e3e7-4e4d4d10c8ee@tarantool.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD99F281DB1F96F126D0DFE9D79B67518B4D288C0911C5BCE1100894C459B0CD1B9EE28DC6E108931037FAA91CCFAABFEA7DA5F81BE5250B97F68897FC172A4A22D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE728F774C865CF4B07EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371DF52D98DC3592C48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D847C9BD09D75DAB8F39EB445FADE3F167117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC47272755C61AA17BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B62CFFCC7B69C47339089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A51DF162A25DF559F182795600D93E4C383D175E29DAB080A8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7506FE1F977233B9BB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3430FC2BC1B917F01874AC83678B20A8BA7B257190C5EA5578DF1B93E662C611C4F8E8768C8159BAFB1D7E09C32AA3244C65ABB35D957F7FB50707885E7C4C1D37795D98D676DD64D0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojTrkTMKMUi4V0AXU2eNzAwg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D192EFBCE293ECDC64D1D968D33A2F92B3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E25FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 1/2] router: drop wait_connected from master discovery X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! On 05.12.2021 18:44, Oleg Babin wrote: > Thanks for your patch. Looks reasonable. > > However I have one question. Before this patch if some > > connection was down we perform wait_connected and in some > > cases it could lead to successful reconnection. Currently we just skip > > broken connections and don't try to reconnect. > > Could it be a problem or we perform reconnection in another place? > > What will be happen if all connections will be down? All connections use reconnect_after option in netbox. Thus netbox handles reconnect. If all are down, netbox_wait_connected won't help either. So you will need to make several master discovery iterations anyway until one is found. Also before this patch netbox_wait_connected() couldn't boost successful reconnection anyhow. It was just waiting. It didn't affect the connection state. After this patch the waiting is dropped to try to talk to the disconnected nodes later on a next master discovery iteration.