Re: [Tarantool-patches] [PATCH v2 luajit 21/26] test: enable <ffi_parse_struct.lua> LuaJIT test

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!
Fixed your comment below.

On 05.02.24, Sergey Bronnikov wrote:
> Hi, Sergey
> 
> thanks for the patch! LGTM with a minor comment
> 
> On 1/29/24 13:45, Sergey Kaplun wrote:
> > This patch changes `dofile()` (which uses an unreliable relative file
> > path and mutates `_G` with global functions to be defined) to the
> > corresponding `require()` of the helper functions. It adds groups with
> > the names of subtests and enables the test in <index>.
> >
> > Part of tarantool/tarantool#9398
> > ---
> >   .../LuaJIT-tests/lib/ffi/ffi_parse_struct.lua | 335 +++++++++---------
> >   test/LuaJIT-tests/lib/ffi/index               |   1 +
> >   2 files changed, 176 insertions(+), 160 deletions(-)
> >
> > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
> > index 16a3d053..cb231c33 100644
> > --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
> > +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
> <snipped>
> >   
> > -do
> > +do --- pragma pack aligment
> typo: alignment

Fixed, thanks!

===================================================================
diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
index 60385810..17ed19fd 100644
--- a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
+++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua
@@ -251,7 +251,7 @@ do --- pragma pack pop
   assert(ffi.sizeof("struct foo_packpop2") == 12)
 end
 
-do --- pragma pack aligment
+do --- pragma pack alignment
   ffi.cdef[[
     #pragma pack(2)
     struct foo_packalign8 {
===================================================================

> >     ffi.cdef[[
> >       #pragma pack(2)
> >       struct foo_packalign8 {
> > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index
> > index 12b6387f..e3a34e30 100644
> > --- a/test/LuaJIT-tests/lib/ffi/index
> > +++ b/test/LuaJIT-tests/lib/ffi/index
> > @@ -19,6 +19,7 @@ ffi_new.lua
> >   ffi_parse_array.lua
> >   ffi_parse_basic.lua
> >   ffi_parse_cdef.lua
> > +ffi_parse_struct.lua
> >   istype.lua
> >   jit_array.lua
> >   jit_complex.lua

-- 
Best regards,
Sergey Kaplun