Re: [Tarantool-patches] [PATCH v2 luajit 23/26] test: enable <lightud.lua> LuaJIT test

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey

thanks for the patch! LGTM

On 1/29/24 13:45, Sergey Kaplun wrote:
> This patch moves the <lightud.lua> test from the <misc> to <lang>
> directory, includes it in <index>, and names subtests. Also, it enables
> tests for all arches and fixes tests for 47-bit lightuserdata because it
> is available since the commit
> 2cacfa8e7ffefb715abf55dc5b0c708c63251868 ("Add support for full-range 64
> bit lightuserdata.")
>
> Part of tarantool/tarantool#9398
> ---
>   test/LuaJIT-tests/lang/index       |  1 +
>   test/LuaJIT-tests/lang/lightud.lua | 89 ++++++++++++++++++++++++++++++
>   test/LuaJIT-tests/misc/lightud.lua | 88 -----------------------------
>   3 files changed, 90 insertions(+), 88 deletions(-)
>   create mode 100644 test/LuaJIT-tests/lang/lightud.lua
>   delete mode 100644 test/LuaJIT-tests/misc/lightud.lua
>
> diff --git a/test/LuaJIT-tests/lang/index b/test/LuaJIT-tests/lang/index
> index 88e2edfa..60cbecfb 100644
> --- a/test/LuaJIT-tests/lang/index
> +++ b/test/LuaJIT-tests/lang/index
> @@ -5,6 +5,7 @@ compare_nan.lua
>   constant
>   for.lua
>   length.lua
> +lightud.lua
>   modulo.lua
>   concat.lua
>   self.lua
> diff --git a/test/LuaJIT-tests/lang/lightud.lua b/test/LuaJIT-tests/lang/lightud.lua
> new file mode 100644
> index 00000000..aee9e85c
> --- /dev/null
> +++ b/test/LuaJIT-tests/lang/lightud.lua
> @@ -0,0 +1,89 @@
> +local ctest = require("libctest")
> +
> +local lightud = ctest.lightud
> +local assert = assert
> +
> +-- x64 lightud tests
> +do --- light userdata comparison and tostring +x64
> +  local ud1 = lightud(0x12345678)
> +  local ud2 = lightud(0x12345678)
> +  assert(ud1 == ud2)
> +  assert(tostring(ud1) == "userdata: 0x12345678")
> +end
> +
> +do --- unequal light userdata comparison +x64
> +  local ud1 = lightud(1)
> +  local ud2 = lightud(2)
> +  assert(ud1 ~= ud2)
> +end
> +
> +do --- big light userdata comparison and tostring +x64
> +  local ud1 = lightud(2^47-1)
> +  local ud2 = lightud(2^47-1)
> +  assert(ud1 == ud2)
> +  assert(tostring(ud1) == "userdata: 0x7fffffffffff")
> +end
> +
> +do --- unequal light userdata comparison JIT +x64
> +  local ud1 = lightud(0x12345678+123*2^32)
> +  local ud2 = lightud(0x12345678+456*2^32)
> +  for i=1,100 do assert(ud1 ~= ud2) end
> +end
> +
> +do --- 47 bits light userdata +x64
> +  assert(tostring(lightud(0x5abc*2^32 + 0xdef01234)) == "userdata: 0x5abcdef01234")
> +  -- Now more than 47 bits are available.
> +  assert(pcall(lightud, 2^47) == true)
> +  assert(pcall(lightud, 2^64-2048) == true)
> +end
> +
> +do --- metatable check
> +  assert(getmetatable(lightud(1)) == nil)
> +end
> +
> +do --- lightuserdata SLOAD value and HREF key
> +  local ud = lightud(12345)
> +  local t = {[ud] = 42}
> +  for i=1,100 do
> +    assert(t[ud] == 42)
> +  end
> +end
> +
> +do --- lightuserdata NEWREF key
> +  local ud = lightud(12345)
> +  for i=1,100 do
> +    local t = {[ud] = 42}
> +    assert(t[ud] == 42)
> +  end
> +end
> +
> +do --- lightuserdata ASTORE/HSTORE value
> +  local ud = lightud(12345)
> +  local t = {}
> +  for i=1,100 do
> +    t[i] = ud
> +  end
> +  assert(t[100] == ud)
> +end
> +
> +do --- lightuserdata sync to stack
> +  local ud = lightud(12345)
> +  local x = nil
> +  for j=1,20 do
> +    for i=1,50 do
> +      x = ud
> +    end
> +    assert(x == ud)
> +  end
> +end
> +
> +do --- lightuserdata vs. number type check
> +  local t = {}
> +  for i=1,200 do t[i] = i end
> +  t[180] = lightud(12345)
> +  local x = 0
> +  assert(not pcall(function(t)
> +    for i=1,200 do x = x + t[i] end
> +  end, t))
> +  assert(x == 16110)
> +end
> diff --git a/test/LuaJIT-tests/misc/lightud.lua b/test/LuaJIT-tests/misc/lightud.lua
> deleted file mode 100644
> index 4974d50f..00000000
> --- a/test/LuaJIT-tests/misc/lightud.lua
> +++ /dev/null
> @@ -1,88 +0,0 @@
> -local ctest = require("ctest")
> -
> -local lightud = ctest.lightud
> -local assert = assert
> -
> --- x64 lightud tests
> -if jit and jit.arch == "x64" then
> -  do
> -    local ud1 = lightud(0x12345678)
> -    local ud2 = lightud(0x12345678)
> -    assert(ud1 == ud2)
> -    assert(tostring(ud1) == "userdata: 0x12345678")
> -  end
> -  do
> -    local ud1 = lightud(1)
> -    local ud2 = lightud(2)
> -    assert(ud1 ~= ud2)
> -  end
> -  do
> -    local ud1 = lightud(2^47-1)
> -    local ud2 = lightud(2^47-1)
> -    assert(ud1 == ud2)
> -    assert(tostring(ud1) == "userdata: 0x7fffffffffff")
> -  end
> -  do
> -    local ud1 = lightud(0x12345678+123*2^32)
> -    local ud2 = lightud(0x12345678+456*2^32)
> -    for i=1,100 do assert(ud1 ~= ud2) end
> -  end
> -  assert(tostring(lightud(0x5abc*2^32 + 0xdef01234)) == "userdata: 0x5abcdef01234")
> -  assert(pcall(lightud, 2^47) == false)
> -  assert(pcall(lightud, 2^64-2048) == false)
> -end
> -
> -assert(getmetatable(lightud(1)) == nil)
> -
> --- lightuserdata SLOAD value and HREF key
> -do
> -  local ud = lightud(12345)
> -  local t = {[ud] = 42}
> -  for i=1,100 do
> -    assert(t[ud] == 42)
> -  end
> -end
> -
> --- lightuserdata NEWREF key
> -do
> -  local ud = lightud(12345)
> -  for i=1,100 do
> -    local t = {[ud] = 42}
> -    assert(t[ud] == 42)
> -  end
> -end
> -
> --- lightuserdata ASTORE/HSTORE value
> -do
> -  local ud = lightud(12345)
> -  local t = {}
> -  for i=1,100 do
> -    t[i] = ud
> -  end
> -  assert(t[100] == ud)
> -end
> -
> --- lightuserdata sync to stack
> -do
> -  local ud = lightud(12345)
> -  local x = nil
> -  for j=1,20 do
> -    for i=1,50 do
> -      x = ud
> -    end
> -    assert(x == ud)
> -  end
> -end
> -
> --- lightuserdata vs. number type check
> -do
> -  local t = {}
> -  for i=1,200 do t[i] = i end
> -  t[180] = lightud(12345)
> -  local x = 0
> -  assert(not pcall(function(t)
> -    for i=1,200 do x = x + t[i] end
> -  end, t))
> -  assert(x == 16110)
> -end
> -