From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A9C019F14C1; Tue, 6 Feb 2024 17:29:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A9C019F14C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707229748; bh=LCG/aZ/rrUqhu4/ul10dU+L1gIrC2ViECwmR0TTd0F4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WKfpTcrHAdyjSoysOttu2tJQhjHQwMvCPdkOy4RsI48UWcAq30PAF019OgqBlQ4aK RhOOpm5wlrK15BwSFRfge1xq7WCZXejODMhBtgofaTcpaETahHn9l7ywI+Yml4fW1/ 9q98srW15FmXv5P2subt0Edo0N/RQZtXXiPLVVlc= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 29DC49F14C0 for ; Tue, 6 Feb 2024 17:29:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 29DC49F14C0 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1rXMRf-000000079H1-01on; Tue, 06 Feb 2024 17:29:07 +0300 Date: Tue, 6 Feb 2024 17:25:09 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51B9726ADA31168F4196B22ED51EBCAFDA182A05F538085040E7EB8E762310DFEB91417EB218679B821FD8C7EAAB3EE486EB7959DB07BACED7B7464F346B62472A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF6699A3AA9BACA6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D8FE4B420C2EEC248638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CC193AC0207B02D78B15A54B14EE3981ABB6022B5BE026E6CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD181150BA43C84913FC3A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B344165809136645C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5F3D665B045C22B9B5002B1117B3ED696D6DB546A5B2E547B54BB1175C6E7DD94823CB91A9FED034534781492E4B8EEAD32941D3B652364A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFC097D28E41E065A09BC669BC64838B880CE49DE363CE39E6DF0438A7C5DEB98045F8ED8E1771A93D807D692F32DC70321BE022A550ABCB54F7DCA6752176DBECA7945C997020B8C25F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnO01sJBq77bdg== X-DA7885C5: A3F3016AAA0F5D50F255D290C0D534F92C6156112E82D6F1EAAD34DFFC52EC2B25D8199D45A524645B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33D66AAFF2609CE4575F24750B090702BEAE55B65C296E8BB1E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 21/26] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment below. On 05.02.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch! LGTM with a minor comment > > On 1/29/24 13:45, Sergey Kaplun wrote: > > This patch changes `dofile()` (which uses an unreliable relative file > > path and mutates `_G` with global functions to be defined) to the > > corresponding `require()` of the helper functions. It adds groups with > > the names of subtests and enables the test in . > > > > Part of tarantool/tarantool#9398 > > --- > > .../LuaJIT-tests/lib/ffi/ffi_parse_struct.lua | 335 +++++++++--------- > > test/LuaJIT-tests/lib/ffi/index | 1 + > > 2 files changed, 176 insertions(+), 160 deletions(-) > > > > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua > > index 16a3d053..cb231c33 100644 > > --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua > > +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua > > > > > -do > > +do --- pragma pack aligment > typo: alignment Fixed, thanks! =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua index 60385810..17ed19fd 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua @@ -251,7 +251,7 @@ do --- pragma pack pop assert(ffi.sizeof("struct foo_packpop2") == 12) end -do --- pragma pack aligment +do --- pragma pack alignment ffi.cdef[[ #pragma pack(2) struct foo_packalign8 { =================================================================== > > ffi.cdef[[ > > #pragma pack(2) > > struct foo_packalign8 { > > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index > > index 12b6387f..e3a34e30 100644 > > --- a/test/LuaJIT-tests/lib/ffi/index > > +++ b/test/LuaJIT-tests/lib/ffi/index > > @@ -19,6 +19,7 @@ ffi_new.lua > > ffi_parse_array.lua > > ffi_parse_basic.lua > > ffi_parse_cdef.lua > > +ffi_parse_struct.lua > > istype.lua > > jit_array.lua > > jit_complex.lua -- Best regards, Sergey Kaplun