From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix HREFK optimization. Date: Thu, 15 Feb 2024 13:42:33 +0000 [thread overview] Message-ID: <Zc4UydiuxLe1pvka@tarantool.org> (raw) In-Reply-To: <20240112132643.106145-1-m.kokryashkin@tarantool.org> Max, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 12.01.24, Maxim Kokryashkin via Tarantool-patches wrote: > From: Mike Pall <mike> > > Contributed by XmiliaH. > > (cherry-picked from commit 91bc6b8ad1f373c1ce9003dc024b2e21fad0e444) > > In `lj_record_idx` when `ix->oldv` is the global nilnode and the > required key is not present in the table, it is possible to pass > the constant key lookup optimization condition because of the > `uint32_t` overflow. Because of that, further recording > incorrectly removes the check for the nilnode, which produces > wrong results when trace is called for a different table. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > --- > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-840-fix-hrefk-optimization > PR: https://github.com/tarantool/tarantool/pull/9591 > Issues: https://github.com/LuaJIT/LuaJIT/issues/840 > https://github.com/tarantool/tarantool/issues/9145 > > src/lj_record.c | 8 +-- > .../lj-840-fix-hrefk-optimization.test.lua | 58 +++++++++++++++++++ > 2 files changed, 62 insertions(+), 4 deletions(-) > create mode 100644 test/tarantool-tests/lj-840-fix-hrefk-optimization.test.lua > <snipped> > -- > 2.43.0 > -- Best regards, IM
prev parent reply other threads:[~2024-02-15 13:54 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-12 13:26 Maxim Kokryashkin via Tarantool-patches 2024-01-15 15:22 ` Sergey Kaplun via Tarantool-patches 2024-02-02 12:21 ` Maxim Kokryashkin via Tarantool-patches 2024-02-05 9:53 ` Sergey Kaplun via Tarantool-patches 2024-02-06 11:09 ` Maxim Kokryashkin via Tarantool-patches 2024-01-16 8:46 ` Sergey Bronnikov via Tarantool-patches 2024-01-16 12:09 ` Sergey Kaplun via Tarantool-patches 2024-01-16 12:53 ` Sergey Bronnikov via Tarantool-patches 2024-01-16 12:54 ` Sergey Bronnikov via Tarantool-patches 2024-02-15 13:42 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Zc4UydiuxLe1pvka@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix HREFK optimization.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox