From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: "Maxim Kokryashkin" <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix HREFK optimization.
Date: Tue, 06 Feb 2024 14:09:08 +0300 [thread overview]
Message-ID: <1707217748.942891107@f553.i.mail.ru> (raw)
In-Reply-To: <ZcCwNPJIbzPgshLO@root>
[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]
Hi, Sergey!
Thanks for the review!
Now this line looks like the following:
| The issue is solved by using `GCSize`, which has a size of
| 64 bits on GC64 builds, instead of `MSize`.
--
Best regards,
Maxim Kokryashkin
>Понедельник, 5 февраля 2024, 12:57 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:
>
>Hi, Maxim!
>Thanks for the fixes!
>LGTM, except a single nit below.
>
>On 02.02.24, Maxim Kokryashkin wrote:
>> Hi, Sergey!
>> Thanks for the review!
>> Fixed your comments, branch is force-pushed.
>> Here is the diff with changes:
>
><snipped>
>
>> New commit message:
>> ===
>> LJ_GC64: Fix HREFK optimization.
>>
>> Contributed by XmiliaH.
>>
>> (cherry-picked from commit 91bc6b8ad1f373c1ce9003dc024b2e21fad0e444)
>>
>> In `lj_record_idx` when `ix->oldv` is the global nilnode and the
>> required key is not present in the table, it is possible to pass
>> the constant key lookup optimization condition because of the
>> `uint32_t` (`MSize`) overflow. Because of that, further recording
>> incorrectly removes the check for the nilnode, which produces
>> wrong results when trace is called for a different table.
>>
>> The issue is solved by using `GCSize`, which has a size of
>
>Minor: I'd say 'which size is defines by the target system' or something
>like that (to mention that it is 32 bit for non-GC64 build).
>
>> 64 bits, instead of `MSize`.
>>
>> Maxim Kokryashkin:
>> * added the description and the test for the problem
>>
>> Part of tarantool/tarantool#9145
>> ===
>
><snipped>
>
>> >
>> > --
>> > Best regards,
>> > Sergey Kaplun
>
>--
>Best regards,
>Sergey Kaplun
[-- Attachment #2: Type: text/html, Size: 2342 bytes --]
next prev parent reply other threads:[~2024-02-06 11:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 13:26 Maxim Kokryashkin via Tarantool-patches
2024-01-15 15:22 ` Sergey Kaplun via Tarantool-patches
2024-02-02 12:21 ` Maxim Kokryashkin via Tarantool-patches
2024-02-05 9:53 ` Sergey Kaplun via Tarantool-patches
2024-02-06 11:09 ` Maxim Kokryashkin via Tarantool-patches [this message]
2024-01-16 8:46 ` Sergey Bronnikov via Tarantool-patches
2024-01-16 12:09 ` Sergey Kaplun via Tarantool-patches
2024-01-16 12:53 ` Sergey Bronnikov via Tarantool-patches
2024-01-16 12:54 ` Sergey Bronnikov via Tarantool-patches
2024-02-15 13:42 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1707217748.942891107@f553.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix HREFK optimization.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox