From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B5007BDDCF2; Thu, 15 Feb 2024 16:54:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B5007BDDCF2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708005263; bh=fWQgI9zyUWjgC2adUQbisl7DMZLbAy8tCDIeLzkCuFE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WESQGuhVz5WPWowxTwAwAsRxWiqIVYttFSsK0W0wyr296OAL7aA4bRkNY6cuAnlTb 5oH3vVETqkZGFRhTgtQQhH0OQqYviIHVzin0C4dq8gbTp4Gs15OYPbl8vCmmiT1xwW kIjcPx0KwmLFuEBWwGCnA6cjGkdLX2234NYPoXyk= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2905EBDDCED for ; Thu, 15 Feb 2024 16:54:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2905EBDDCED Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1racBc-0000000HOer-0zdE; Thu, 15 Feb 2024 16:54:00 +0300 Date: Thu, 15 Feb 2024 13:42:33 +0000 To: Maxim Kokryashkin Message-ID: References: <20240112132643.106145-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240112132643.106145-1-m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9001F8F2F6BAD20218FDFC93A65F85DDC59E3B8317EBE436000894C459B0CD1B97CE1FEBF754B2679C0B932E609672789578BB40A139EA63558736E605CE1096F4DF7BC4678047644 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CE17C7754E00FC028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D887A23C28FB2FC92059BD24E2547BDA494EC258FF4D1F5D23CC7F00164DA146DAFE8445B8C89999728AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D8803F1AB874ED890284AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C325C33BDE98D8A053BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C321259270BBF67A2035872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5BE712DC56F4CC9265002B1117B3ED696851E03F6F398ABB6E772F934B9BCD185823CB91A9FED034534781492E4B8EEAD0AA277257C6A5E3DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3447DF5779098ECEE9AE785A27C60BFB12125A2703FAAE72A7875FBA2C4A87A2B288264EA6FE846F641D7E09C32AA3244C706F11301FAA565313EA5626864FADBF251827B339E245A1EA455F16B58544A21C197AAF4D2E4732E9CAF2BECF134D6894F255A82739648EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQ9gr3ZFpXEmGKb14bUOUCA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5316205F424246C54467FC47A557B39A39B0EB494FFB3AE6ACFE6697CA7BE27BA90F5EE5212A79745119D086FC03DADA47A24EDF3BD9585A06DEEABBE9EE6587A054198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix HREFK optimization. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 12.01.24, Maxim Kokryashkin via Tarantool-patches wrote: > From: Mike Pall > > Contributed by XmiliaH. > > (cherry-picked from commit 91bc6b8ad1f373c1ce9003dc024b2e21fad0e444) > > In `lj_record_idx` when `ix->oldv` is the global nilnode and the > required key is not present in the table, it is possible to pass > the constant key lookup optimization condition because of the > `uint32_t` overflow. Because of that, further recording > incorrectly removes the check for the nilnode, which produces > wrong results when trace is called for a different table. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > --- > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-840-fix-hrefk-optimization > PR: https://github.com/tarantool/tarantool/pull/9591 > Issues: https://github.com/LuaJIT/LuaJIT/issues/840 > https://github.com/tarantool/tarantool/issues/9145 > > src/lj_record.c | 8 +-- > .../lj-840-fix-hrefk-optimization.test.lua | 58 +++++++++++++++++++ > 2 files changed, 62 insertions(+), 4 deletions(-) > create mode 100644 test/tarantool-tests/lj-840-fix-hrefk-optimization.test.lua > > -- > 2.43.0 > -- Best regards, IM