Re: [Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
One more comment below:

On 23.10.23, Sergey Kaplun via Tarantool-patches wrote:
> Hi, Sergey!
> Thanks for the fixes!
> LGTM, just minor nits below.
> 

<snipped>

> > >> diff --git a/cmake/CodeSpell.cmake b/cmake/CodeSpell.cmake
> > >> new file mode 100644
> > >> index 00000000..c4d3555d
> > >> --- /dev/null
> > >> +++ b/cmake/CodeSpell.cmake
> > >> @@ -0,0 +1,36 @@
> > >> +find_program(CODESPELL codespell)
> > >> +
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/lj_mapi.c)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/lj_sysprof.c)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/lj_utils_leb128.c)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/lj_wbuf.c)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/luajit-gdb.py)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/luajit_lldb.py)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/test/CMakeLists.txt)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/test/tarantool-c-tests)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/test/tarantool-tests)
> > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/tools)
> > > Also, the following files should be checked:
> > >
> > > * src/lib_misc.c
> > > * src/lj_memprof.c
> > > * src/lj_memprof.h
> > > * src/lj_sysprof.h
> > > * src/lj_utils.h
> > > * src/lj_wbuf.h
> > > * src/lmisclib.h
> > > * test/LuaJIT-tests/CMakeLists.txt
> > > * test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
> > > * test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
> > > * test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt
> > > * test/lua-Harness-tests/CMakeLists.txt
> > 
> > 
> > Added:
> > 
> > --- a/cmake/CodeSpell.cmake
> > +++ b/cmake/CodeSpell.cmake
> > @@ -1,13 +1,25 @@
> >   find_program(CODESPELL codespell)
> > 
> >   string(JOIN "," CODESPELL_WHITELIST
> > +  ${PROJECT_SOURCE_DIR}/src/lib_misc.c
> >     ${PROJECT_SOURCE_DIR}/src/lj_mapi.c
> > +  ${PROJECT_SOURCE_DIR}/src/lj_memprof.c
> > +  ${PROJECT_SOURCE_DIR}/src/lj_memprof.h
> >     ${PROJECT_SOURCE_DIR}/src/lj_sysprof.c
> > +  ${PROJECT_SOURCE_DIR}/src/lj_sysprof.h
> > +  ${PROJECT_SOURCE_DIR}/src/lj_utils.h
> >     ${PROJECT_SOURCE_DIR}/src/lj_utils_leb128.c
> >     ${PROJECT_SOURCE_DIR}/src/lj_wbuf.c
> > +  ${PROJECT_SOURCE_DIR}/src/lj_wbuf.h
> > +  ${PROJECT_SOURCE_DIR}/src/lmisclib.h
> >     ${PROJECT_SOURCE_DIR}/src/luajit-gdb.py
> >     ${PROJECT_SOURCE_DIR}/src/luajit_lldb.py
> >     ${PROJECT_SOURCE_DIR}/test/CMakeLists.txt
> > +  ${PROJECT_SOURCE_DIR}/test/lua-Harness-tests/CMakeLists.txt
> > +  ${PROJECT_SOURCE_DIR}/test/LuaJIT-tests/CMakeLists.txt
> > +  ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
> > +  ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
> > + ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt
> >     ${PROJECT_SOURCE_DIR}/test/tarantool-c-tests
> >     ${PROJECT_SOURCE_DIR}/test/tarantool-tests
> >     ${PROJECT_SOURCE_DIR}/tools
> 
> Side note: within vim's (sort 'l' is greater then 'L', see `man ascii`),
> but I'm OK with this order too.

Sorry, I've forgot about <src/lj_symtab.c> <src/lj_symtab.h>.


-- 
Best regards,
Sergey Kaplun