From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B383B690FC6; Tue, 31 Oct 2023 09:47:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B383B690FC6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1698734845; bh=VVJNb2NDNNa/4S9/K1Itg7IdyQrHpFVrUdQQQZiU6bA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Ut9ILxpoVquhjOiKTBFIzhbrBGjzGEwmdWVUqAwSDn7FKEOTxFeKfb+aMEYXysRPF eXHtPuHa/ztGH0C9+AVg3beVwCT9ZhO13wNbTEvQJgUIle12NGi8Nzr6g7AdKTebF9 GG+G01rauMXgxsQ5ZQzG+ymXK5LZKBK6ujOA3L0U= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9065766A689 for ; Tue, 31 Oct 2023 09:47:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9065766A689 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1qxiX5-0000T4-Pl; Tue, 31 Oct 2023 09:47:24 +0300 Date: Tue, 31 Oct 2023 09:42:52 +0300 To: Sergey Bronnikov , Sergey Bronnikov , tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com Message-ID: References: <0f1c6ed9f0bdade86631edc135839e607f3bb7f6.1697042800.git.sergeyb@tarantool.org> <4b791cd8-0174-4cff-9c4d-7faa5eff8550@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9C931D0C4A91E713028A6B45E8800B8D808196D39FA30EE0600894C459B0CD1B912990CE1BBAA35325E5B4F678280BF5F35D483041E259D06906DE0852CB23FE4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CE4525FFB91B9BBCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B4ADA525623CF2D68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D847A150B5C2DA8B4018781692576FB1C5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC60CDF180582EB8FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C06B017D46BF743B9968655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CFC839A7D10C5E1E9C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A552B1E9071CC6604A75E9E95E7E919C24C19F52DCC456D8C8F87CCE6106E1FC07E67D4AC08A07B9B0F254576263B31EA9CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF18F9CF80A0C744895FB3436CEEA2D4966A5F87509963C33FAA9ED8B92C5424DD8B42E79199D3D3ED516A7BA57488566279F63A19B298C24E41C88E7EE90FDA90A74DFFEFA5DC0E7F02C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPJ6ruIekffJvfO118RNn6w== X-DA7885C5: 1FD5307FA956DFB9F8135D4FC1B888987F0650F82425FBC15C7F34BC5662EA83262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B403A39BB66108C0C31125888B861FE460FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! One more comment below: On 23.10.23, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the fixes! > LGTM, just minor nits below. > > > >> diff --git a/cmake/CodeSpell.cmake b/cmake/CodeSpell.cmake > > >> new file mode 100644 > > >> index 00000000..c4d3555d > > >> --- /dev/null > > >> +++ b/cmake/CodeSpell.cmake > > >> @@ -0,0 +1,36 @@ > > >> +find_program(CODESPELL codespell) > > >> + > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/lj_mapi.c) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/lj_sysprof.c) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/lj_utils_leb128.c) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/lj_wbuf.c) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/luajit-gdb.py) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/src/luajit_lldb.py) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/test/CMakeLists.txt) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/test/tarantool-c-tests) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/test/tarantool-tests) > > >> +list(APPEND CODESPELL_WHITELIST ${PROJECT_SOURCE_DIR}/tools) > > > Also, the following files should be checked: > > > > > > * src/lib_misc.c > > > * src/lj_memprof.c > > > * src/lj_memprof.h > > > * src/lj_sysprof.h > > > * src/lj_utils.h > > > * src/lj_wbuf.h > > > * src/lmisclib.h > > > * test/LuaJIT-tests/CMakeLists.txt > > > * test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt > > > * test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt > > > * test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt > > > * test/lua-Harness-tests/CMakeLists.txt > > > > > > Added: > > > > --- a/cmake/CodeSpell.cmake > > +++ b/cmake/CodeSpell.cmake > > @@ -1,13 +1,25 @@ > >  find_program(CODESPELL codespell) > > > >  string(JOIN "," CODESPELL_WHITELIST > > +  ${PROJECT_SOURCE_DIR}/src/lib_misc.c > >    ${PROJECT_SOURCE_DIR}/src/lj_mapi.c > > +  ${PROJECT_SOURCE_DIR}/src/lj_memprof.c > > +  ${PROJECT_SOURCE_DIR}/src/lj_memprof.h > >    ${PROJECT_SOURCE_DIR}/src/lj_sysprof.c > > +  ${PROJECT_SOURCE_DIR}/src/lj_sysprof.h > > +  ${PROJECT_SOURCE_DIR}/src/lj_utils.h > >    ${PROJECT_SOURCE_DIR}/src/lj_utils_leb128.c > >    ${PROJECT_SOURCE_DIR}/src/lj_wbuf.c > > +  ${PROJECT_SOURCE_DIR}/src/lj_wbuf.h > > +  ${PROJECT_SOURCE_DIR}/src/lmisclib.h > >    ${PROJECT_SOURCE_DIR}/src/luajit-gdb.py > >    ${PROJECT_SOURCE_DIR}/src/luajit_lldb.py > >    ${PROJECT_SOURCE_DIR}/test/CMakeLists.txt > > +  ${PROJECT_SOURCE_DIR}/test/lua-Harness-tests/CMakeLists.txt > > +  ${PROJECT_SOURCE_DIR}/test/LuaJIT-tests/CMakeLists.txt > > +  ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt > > +  ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt > > + ${PROJECT_SOURCE_DIR}/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt > >    ${PROJECT_SOURCE_DIR}/test/tarantool-c-tests > >    ${PROJECT_SOURCE_DIR}/test/tarantool-tests > >    ${PROJECT_SOURCE_DIR}/tools > > Side note: within vim's (sort 'l' is greater then 'L', see `man ascii`), > but I'm OK with this order too. Sorry, I've forgot about . -- Best regards, Sergey Kaplun