From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Bronnikov" <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 4/4][v2] ci: enable codespell
Date: Thu, 12 Oct 2023 13:45:13 +0300 [thread overview]
Message-ID: <1697107513.168680457@f747.i.mail.ru> (raw)
In-Reply-To: <2240e188707965f350ee603f2260de95d6623fb7.1697042800.git.sergeyb@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]
Hi, Sergey!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
>Среда, 11 октября 2023, 19:55 +03:00 от Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>:
>
>From: Sergey Bronnikov < sergeyb@tarantool.org >
>
>The patch adds a GitHub Action, that installs codespell, and adds a job,
>that runs codespell using CMake target "LuaJIT-codespell".
>---
> .github/workflows/lint.yml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
>index 758ff33e..8147b053 100644
>--- a/.github/workflows/lint.yml
>+++ b/.github/workflows/lint.yml
>@@ -29,7 +29,7 @@ concurrency:
> jobs:
> test-luacheck:
> runs-on: [self-hosted, lightweight, Linux, x86_64]
>- name: LuaJIT linters (luacheck, flake8)
>+ name: LuaJIT linters (luacheck, flake8, codespell)
> steps:
> - uses: actions/checkout@v3
> with:
>@@ -44,6 +44,7 @@ jobs:
> sudo apt -y install cmake ninja-build lua5.1 luarocks
> sudo luarocks install luacheck
> sudo pip3 install flake8==6.1.0
>+ sudo pip3 install codespell==2.2.5
> # Set CMAKE_BUILD_PARALLEL_LEVEL environment variable to
> # limit the number of parallel jobs for build/test step.
> echo CMAKE_BUILD_PARALLEL_LEVEL=$(($(nproc) + 1)) | tee -a $GITHUB_ENV
>--
>2.34.1
[-- Attachment #2: Type: text/html, Size: 2452 bytes --]
next prev parent reply other threads:[~2023-10-12 10:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:52 [Tarantool-patches] [PATCH luajit 0/4][v2] Fix typos and " Sergey Bronnikov via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 1/4][v2] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-10-12 10:33 ` Maxim Kokryashkin via Tarantool-patches
2023-10-23 8:50 ` Sergey Kaplun via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 2/4][v2] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-10-12 10:34 ` Maxim Kokryashkin via Tarantool-patches
2023-10-23 8:52 ` Sergey Kaplun via Tarantool-patches
2023-10-23 14:13 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:27 ` Sergey Kaplun via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell Sergey Bronnikov via Tarantool-patches
2023-10-11 19:33 ` Sergey Bronnikov via Tarantool-patches
2023-10-12 10:43 ` Maxim Kokryashkin via Tarantool-patches
2023-10-12 13:28 ` Sergey Bronnikov via Tarantool-patches
2023-10-12 18:46 ` Maxim Kokryashkin via Tarantool-patches
2023-10-17 14:50 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 9:20 ` Sergey Kaplun via Tarantool-patches
2023-10-23 12:29 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:38 ` Sergey Kaplun via Tarantool-patches
2023-10-31 6:42 ` Sergey Kaplun via Tarantool-patches
2023-10-31 10:50 ` Sergey Bronnikov via Tarantool-patches
2023-10-31 11:31 ` Sergey Kaplun via Tarantool-patches
2023-10-31 11:53 ` Maxim Kokryashkin via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 4/4][v2] ci: enable codespell Sergey Bronnikov via Tarantool-patches
2023-10-12 10:45 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-10-23 8:53 ` Sergey Kaplun via Tarantool-patches
2023-11-16 16:19 ` [Tarantool-patches] [PATCH luajit 0/4][v2] Fix typos and " Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1697107513.168680457@f747.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH luajit 4/4][v2] ci: enable codespell' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox