Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Fix maxslots when recording BC_VARG, part 2.
Date: Tue, 18 Jul 2023 08:18:38 +0000	[thread overview]
Message-ID: <ZLZK3q6c5MgMFZxC@tarantool.org> (raw)
In-Reply-To: <d89c7a1979bb358fe2675263fba0e37683f678b1.1688985402.git.skaplun@tarantool.org>

Sergey,

Thanks for the patch! Again, everything is fine with the commit message
after resolving the comments left by Max, but the black voodoo magic
condition is still unclear (see my comments to the first patch).

On 10.07.23, Sergey Kaplun wrote:
> From: Mike Pall <mike>
> 

<snipped>

> diff --git a/test/tarantool-tests/lj-1024-varg-maxslot.test.lua b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua
> index 14270595..f8d74e8a 100644
> --- a/test/tarantool-tests/lj-1024-varg-maxslot.test.lua
> +++ b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua

<snipped>

> @@ -20,4 +20,21 @@ end
>  
>  test:ok(true, 'BC_VARG recording 0th frame depth')
>  
> +-- Now the same case, but with additional frame, so VARG slots
> +-- are defined on the trace.
> +local function bump_varg_frame(...)
> +  -- BC_VARG 1 1 0. `...` is nil (argument for the script).
> +  -- luacheck: ignore
> +  -- XXX: some condition to use several slots on the Lua stack.
> +  anchor = 1 >= 1, ...

Clarification is required here as well as for the first test.

> +end
> +
> +counter = 0
> +while counter < 3 do
> +  counter = counter + 1
> +  bump_varg_frame()
> +end
> +
> +test:ok(true, 'BC_VARG recording with defined on trace VARG slots')

Minor: I believe it should be "BC_VARG recording with VARG slots defined
on the trace", but I might be missing something.

> +
>  os.exit(test:check() and 0 or 1)
> -- 
> 2.34.1
> 

-- 
Best regards,
IM

  parent reply	other threads:[~2023-07-18  8:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 10:46 [Tarantool-patches] [PATCH luajit 0/2] Fix maxslots when recording BC_VARG Sergey Kaplun via Tarantool-patches
2023-07-10 10:46 ` [Tarantool-patches] [PATCH luajit 1/2] " Sergey Kaplun via Tarantool-patches
2023-07-14 12:16   ` Maxim Kokryashkin via Tarantool-patches
2023-07-15 15:11     ` Sergey Kaplun via Tarantool-patches
2023-07-17 11:00       ` Maxim Kokryashkin via Tarantool-patches
2023-07-18  8:18   ` Igor Munkin via Tarantool-patches
2023-07-18 14:12     ` Sergey Kaplun via Tarantool-patches
2023-07-18 14:23       ` Igor Munkin via Tarantool-patches
2023-07-10 10:46 ` [Tarantool-patches] [PATCH luajit 2/2] Fix maxslots when recording BC_VARG, part 2 Sergey Kaplun via Tarantool-patches
2023-07-14 12:41   ` Maxim Kokryashkin via Tarantool-patches
2023-07-15 15:08     ` Sergey Kaplun via Tarantool-patches
2023-07-17 11:03       ` Maxim Kokryashkin via Tarantool-patches
2023-07-18  8:18   ` Igor Munkin via Tarantool-patches [this message]
2023-07-18 14:19     ` Sergey Kaplun via Tarantool-patches
2023-07-18 14:24       ` Igor Munkin via Tarantool-patches
2023-07-20 18:37 ` [Tarantool-patches] [PATCH luajit 0/2] Fix maxslots when recording BC_VARG Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLZK3q6c5MgMFZxC@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 2/2] Fix maxslots when recording BC_VARG, part 2.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox