From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix maxslots when recording BC_VARG. Date: Tue, 18 Jul 2023 08:18:29 +0000 [thread overview] Message-ID: <ZLZK1R6FiHljQznb@tarantool.org> (raw) In-Reply-To: <323f1c0c6a33a31f0ad7691bd68886bfd195eae4.1688985402.git.skaplun@tarantool.org> Sergey, Thanks for the patch! The commit message is OK after fixing Max nits, but I still have some questions regarding the test. On 10.07.23, Sergey Kaplun wrote: > From: Mike Pall <mike> <snipped> > diff --git a/test/tarantool-tests/lj-1024-varg-maxslot.test.lua b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua > new file mode 100644 > index 00000000..14270595 > --- /dev/null > +++ b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua > @@ -0,0 +1,23 @@ > +local tap = require('tap') > +local test = tap.test('lj-noticket-varg-usedef'):skipcond({ Now you have a ticket number. > + ['Test requires JIT enabled'] = not jit.status(), > +}) > + > +test:plan(1) > + > +jit.opt.start('hotloop=1') > + > +local counter = 0 > +-- luacheck: ignore > +local anchor > +while counter < 3 do > + counter = counter + 1 > + -- BC_VARG 5 1 0. `...` is nil (argument for the script). > + -- luacheck: ignore > + -- XXX: some condition to use several slots on the Lua stack. > + anchor = 1 >= 1, ... Well, I have no idea, why this black voodoo magic is required. Comment doesn't make it clear either. It would be nice to describe the purpose of this in a more verbose way. > +end > + > +test:ok(true, 'BC_VARG recording 0th frame depth') > + > +os.exit(test:check() and 0 or 1) > -- > 2.34.1 > -- Best regards, IM
next prev parent reply other threads:[~2023-07-18 8:29 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-10 10:46 [Tarantool-patches] [PATCH luajit 0/2] " Sergey Kaplun via Tarantool-patches 2023-07-10 10:46 ` [Tarantool-patches] [PATCH luajit 1/2] " Sergey Kaplun via Tarantool-patches 2023-07-14 12:16 ` Maxim Kokryashkin via Tarantool-patches 2023-07-15 15:11 ` Sergey Kaplun via Tarantool-patches 2023-07-17 11:00 ` Maxim Kokryashkin via Tarantool-patches 2023-07-18 8:18 ` Igor Munkin via Tarantool-patches [this message] 2023-07-18 14:12 ` Sergey Kaplun via Tarantool-patches 2023-07-18 14:23 ` Igor Munkin via Tarantool-patches 2023-07-10 10:46 ` [Tarantool-patches] [PATCH luajit 2/2] Fix maxslots when recording BC_VARG, part 2 Sergey Kaplun via Tarantool-patches 2023-07-14 12:41 ` Maxim Kokryashkin via Tarantool-patches 2023-07-15 15:08 ` Sergey Kaplun via Tarantool-patches 2023-07-17 11:03 ` Maxim Kokryashkin via Tarantool-patches 2023-07-18 8:18 ` Igor Munkin via Tarantool-patches 2023-07-18 14:19 ` Sergey Kaplun via Tarantool-patches 2023-07-18 14:24 ` Igor Munkin via Tarantool-patches 2023-07-20 18:37 ` [Tarantool-patches] [PATCH luajit 0/2] Fix maxslots when recording BC_VARG Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZLZK1R6FiHljQznb@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] Fix maxslots when recording BC_VARG.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox