From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DD2B2482AA0; Tue, 18 Jul 2023 11:29:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD2B2482AA0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689668964; bh=ahA4ISNxN2lG4HG8eOSo8Y6Vj7/9O0y6f/gAJraLvso=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kHFcdx1v5cwSFZW3Hg4HqyuZ1UEbE9jsccHUYcsknR01lK7YEen3ErnEyNm812bWU jLEljkjJtbIM7HXuv7q7Ig+nf9kgMbQum1uQXimHjg7MFD1XcBWgW+CskR7MjurTF9 Qhfo+AAP04/fZVPl6mLtZFIYhNzgg6P5nLJ95Skk= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [95.163.41.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 618CC482AA0 for ; Tue, 18 Jul 2023 11:29:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 618CC482AA0 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1qLg5B-003bYm-Ij; Tue, 18 Jul 2023 11:29:21 +0300 Date: Tue, 18 Jul 2023 08:18:29 +0000 To: Sergey Kaplun Message-ID: References: <323f1c0c6a33a31f0ad7691bd68886bfd195eae4.1688985402.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <323f1c0c6a33a31f0ad7691bd68886bfd195eae4.1688985402.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A075ED639652919769701E3F3AF1B18C87E42114AF825CE1182A05F5380850408D7F16DB3460364699D2934F666F03D525126A7F1DE27D7BC6AF467C247E585D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F0ABDA2F087648F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637603D0B7FC8E46DFC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A58B0EC749BFD8743507B78658FE8E64117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520437C869540D2AB0FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9040F9FF01DFDA4A84AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C30942DC5495D0595E76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C837C4FEFBD186071C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5C7A0E3243D4CB2CECE6D5DDCECECB27DC2080C3C46767F69F87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF7F72B746943B37E8F45D504FE553D3D5903DDF2852E73229B85FB772D2E1D999D9E67331CBA3B6E4DA6E887A44188BD6D84B7BE6643CC67FFCF3220985757ABAA74DFFEFA5DC0E7F02C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojLxQD/rvAZi46B22Q7+p3Ag== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531D9A00BC3AEB2FF0ACBB887014724F9BC65728DF1CB480C8B2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix maxslots when recording BC_VARG. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! The commit message is OK after fixing Max nits, but I still have some questions regarding the test. On 10.07.23, Sergey Kaplun wrote: > From: Mike Pall > diff --git a/test/tarantool-tests/lj-1024-varg-maxslot.test.lua b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua > new file mode 100644 > index 00000000..14270595 > --- /dev/null > +++ b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua > @@ -0,0 +1,23 @@ > +local tap = require('tap') > +local test = tap.test('lj-noticket-varg-usedef'):skipcond({ Now you have a ticket number. > + ['Test requires JIT enabled'] = not jit.status(), > +}) > + > +test:plan(1) > + > +jit.opt.start('hotloop=1') > + > +local counter = 0 > +-- luacheck: ignore > +local anchor > +while counter < 3 do > + counter = counter + 1 > + -- BC_VARG 5 1 0. `...` is nil (argument for the script). > + -- luacheck: ignore > + -- XXX: some condition to use several slots on the Lua stack. > + anchor = 1 >= 1, ... Well, I have no idea, why this black voodoo magic is required. Comment doesn't make it clear either. It would be nice to describe the purpose of this in a more verbose way. > +end > + > +test:ok(true, 'BC_VARG recording 0th frame depth') > + > +os.exit(test:check() and 0 or 1) > -- > 2.34.1 > -- Best regards, IM