From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5202E50D70E; Tue, 18 Jul 2023 11:29:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5202E50D70E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689668993; bh=2Vv8kNPj2wKKOSgy/E1D9LCsya7WgMbpMkqhOGg1Z0U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rSKbG2qTOCQzfqsWMK0cmmmcnSiiYmuwA7N0NIut33LqTnH3XqVRz0IWHU0cGhvwq pC0G874FJxewHyPVsPQSeJxgSeinvSugkUlP5rJFW9Uct4gOgONv5miiat2Jc2io8/ 1vONsjnNO5ljpzx0paJ46d0h60dBsNPtdOMSrxUU= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [95.163.41.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 54BB750D70D for ; Tue, 18 Jul 2023 11:29:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 54BB750D70D Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1qLg5K-004FZk-BQ; Tue, 18 Jul 2023 11:29:30 +0300 Date: Tue, 18 Jul 2023 08:18:38 +0000 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A075ED63965291970579FBC130BD7639A4E6932D6ABD2688182A05F5380850401084A1F3567E3DE5039C07399208A14154BE25EF93D5148FEEA4FD5B542D4146 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73A0E02362971E860EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B84F9009663064BD8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D82A8B302996F87AE32BAD0703DC1B0E6E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA9040F9FF01DFDA4A84AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C30942DC5495D0595E76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C837C4FEFBD186071C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A56A7760636E84A04F89BFCF38E08E08CAEBDB71FF3E8A72F2F87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF841D3EF8B82627E19A0DCD2B6A57A0FD328AA431BE779C5359986775FB41CA58C2F598A3E54AB451DA6E887A44188BD6680C2E79CDAEECDC88C553084BC957C7A74DFFEFA5DC0E7F02C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojLxQD/rvAZi4BVjDFf8TDFQ== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531D9A00BC3AEB2FF0A377BE4EF26A5F290EAACC7A9F8A873042326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Fix maxslots when recording BC_VARG, part 2. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! Again, everything is fine with the commit message after resolving the comments left by Max, but the black voodoo magic condition is still unclear (see my comments to the first patch). On 10.07.23, Sergey Kaplun wrote: > From: Mike Pall > > diff --git a/test/tarantool-tests/lj-1024-varg-maxslot.test.lua b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua > index 14270595..f8d74e8a 100644 > --- a/test/tarantool-tests/lj-1024-varg-maxslot.test.lua > +++ b/test/tarantool-tests/lj-1024-varg-maxslot.test.lua > @@ -20,4 +20,21 @@ end > > test:ok(true, 'BC_VARG recording 0th frame depth') > > +-- Now the same case, but with additional frame, so VARG slots > +-- are defined on the trace. > +local function bump_varg_frame(...) > + -- BC_VARG 1 1 0. `...` is nil (argument for the script). > + -- luacheck: ignore > + -- XXX: some condition to use several slots on the Lua stack. > + anchor = 1 >= 1, ... Clarification is required here as well as for the first test. > +end > + > +counter = 0 > +while counter < 3 do > + counter = counter + 1 > + bump_varg_frame() > +end > + > +test:ok(true, 'BC_VARG recording with defined on trace VARG slots') Minor: I believe it should be "BC_VARG recording with VARG slots defined on the trace", but I might be missing something. > + > os.exit(test:check() and 0 or 1) > -- > 2.34.1 > -- Best regards, IM