Re: [Tarantool-patches] [PATCH luajit 0/2] Fix tonumber("-0") inconsistencies

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, 2.10 and 1.10.

On 26.01.22, Sergey Kaplun wrote:
> This patchset fixes incorrect behaviour for `tonumber("-0")` different
> from Lua 5.1.
> 
> The first patch fixes it for non-dualnum mode (default on x86 and x64).
> The second fixes it for dual-number mode too.
> So, there is the corresponding skipcond in the test for the first patch
> that is removed in the next patch.
> 
> Related issues/PR:
> * https://github.com/LuaJIT/LuaJIT/issues/528
> * https://github.com/LuaJIT/LuaJIT/pull/787
> * https://github.com/tarantool/tarantool/issues/6548
> Branch: https://github.com/tarantool/tarantool/tree/skaplun/lj-528-tonumber-0-full-ci
> Tarantool branch: https://github.com/tarantool/luajit/tree/skaplun/lj-528-tonumber-0-full-ci
> 
> Mike Pall (2):
>   Fix tonumber("-0").
>   Fix tonumber("-0") in dual-number mode.
> 
>  src/lj_strscan.c                                | 13 ++++++++-----
>  test/tarantool-tests/lj-528-tonumber-0.test.lua | 13 +++++++++++++
>  2 files changed, 21 insertions(+), 5 deletions(-)
>  create mode 100644 test/tarantool-tests/lj-528-tonumber-0.test.lua
> 
> -- 
> 2.34.1
> 

-- 
Best regards,
IM