Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>,
	Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 0/2] Fix tonumber("-0") inconsistencies
Date: Wed, 26 Jan 2022 15:19:32 +0300	[thread overview]
Message-ID: <cover.1643199076.git.skaplun@tarantool.org> (raw)

This patchset fixes incorrect behaviour for `tonumber("-0")` different
from Lua 5.1.

The first patch fixes it for non-dualnum mode (default on x86 and x64).
The second fixes it for dual-number mode too.
So, there is the corresponding skipcond in the test for the first patch
that is removed in the next patch.

Related issues/PR:
* https://github.com/LuaJIT/LuaJIT/issues/528
* https://github.com/LuaJIT/LuaJIT/pull/787
* https://github.com/tarantool/tarantool/issues/6548
Branch: https://github.com/tarantool/tarantool/tree/skaplun/lj-528-tonumber-0-full-ci
Tarantool branch: https://github.com/tarantool/luajit/tree/skaplun/lj-528-tonumber-0-full-ci

Mike Pall (2):
  Fix tonumber("-0").
  Fix tonumber("-0") in dual-number mode.

 src/lj_strscan.c                                | 13 ++++++++-----
 test/tarantool-tests/lj-528-tonumber-0.test.lua | 13 +++++++++++++
 2 files changed, 21 insertions(+), 5 deletions(-)
 create mode 100644 test/tarantool-tests/lj-528-tonumber-0.test.lua


             reply	other threads:[~2022-01-26 12:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 12:19 Sergey Kaplun via Tarantool-patches [this message]
2022-01-26 12:19 ` [Tarantool-patches] [PATCH luajit 1/2] Fix tonumber("-0") Sergey Kaplun via Tarantool-patches
2022-06-27 13:47   ` Igor Munkin via Tarantool-patches
2022-06-27 20:29   ` sergos via Tarantool-patches
2022-01-26 12:19 ` [Tarantool-patches] [PATCH luajit 2/2] Fix tonumber("-0") in dual-number mode Sergey Kaplun via Tarantool-patches
2022-01-27  9:50   ` Sergey Kaplun via Tarantool-patches
2022-06-27 13:48   ` Igor Munkin via Tarantool-patches
2022-06-27 15:51   ` sergos via Tarantool-patches
2022-06-30 12:09 ` [Tarantool-patches] [PATCH luajit 0/2] Fix tonumber("-0") inconsistencies Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1643199076.git.skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=sergos@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 0/2] Fix tonumber("-0") inconsistencies' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox