From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 96BB06ECE3; Thu, 30 Jun 2022 15:16:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 96BB06ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656591381; bh=zwWXHIFFoiS8t0wqncrUs3lcr+BGqIZWKo26pJvqHxw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F926Rrzpn+83ME2IdfyIKCEHhbyuSAl0bIaVfZRTRBEixvvys6XzWpkVATctvzcKq xhjx3ZJNg9C6Tm8XVZA3Jo07r4FtkrI+azubxp7o1joAYRNOQm53kKoDn3Yw72wMQz REY6KH3+Xd8xpP7dlky/M5APZPupInvfE0SDJ+C4= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 203B86ECE3 for ; Thu, 30 Jun 2022 15:16:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 203B86ECE3 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1o6t5n-0005bO-CS; Thu, 30 Jun 2022 15:16:19 +0300 Date: Thu, 30 Jun 2022 15:09:08 +0300 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9F05DDD76985F91266E63A67932217827FE9DC1A3676C2844182A05F53808504036C767D42F1135EF145A6FCFD24E7F76812B15D6E166B47483A66BA20B282039 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7705F446BE41E38A1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063720E5706DB08A2EAB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8916110CB6A2F8980C353C0AD0212E4ED117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B8C7ADC89C2F0B2A5A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CD0F529D6CE73765543847C11F186F3C59DAA53EE0834AAEE X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1CE327B8A3FCA1300E5198DA281EDCF87C1046402E29CC3AF1AD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FA5A4D623E7343BB9B6861C57CD633F887ECFE77AEA71611230925A928B8FF4A6FC788A8AA4DAB251D7E09C32AA3244CD771CCF1D4551A3F902BF8181FA06959FE8DA44ABE2443F7927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhvrbUd41KJlhtzYfC2kEGQ== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E367E83D2FB2469D1B2F5776D79F3A041A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 0/2] Fix tonumber("-0") inconsistencies X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, 2.10 and 1.10. On 26.01.22, Sergey Kaplun wrote: > This patchset fixes incorrect behaviour for `tonumber("-0")` different > from Lua 5.1. > > The first patch fixes it for non-dualnum mode (default on x86 and x64). > The second fixes it for dual-number mode too. > So, there is the corresponding skipcond in the test for the first patch > that is removed in the next patch. > > Related issues/PR: > * https://github.com/LuaJIT/LuaJIT/issues/528 > * https://github.com/LuaJIT/LuaJIT/pull/787 > * https://github.com/tarantool/tarantool/issues/6548 > Branch: https://github.com/tarantool/tarantool/tree/skaplun/lj-528-tonumber-0-full-ci > Tarantool branch: https://github.com/tarantool/luajit/tree/skaplun/lj-528-tonumber-0-full-ci > > Mike Pall (2): > Fix tonumber("-0"). > Fix tonumber("-0") in dual-number mode. > > src/lj_strscan.c | 13 ++++++++----- > test/tarantool-tests/lj-528-tonumber-0.test.lua | 13 +++++++++++++ > 2 files changed, 21 insertions(+), 5 deletions(-) > create mode 100644 test/tarantool-tests/lj-528-tonumber-0.test.lua > > -- > 2.34.1 > -- Best regards, IM