Re: [Tarantool-patches] [PATCH luajit v2 0/3] memprof: enrich symtab when meeting new prototype

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Misha,

Thanks for the series!

I've fixed all vital comments by Sergey, and few critical issues I've
found by myself, LGTM otherwise. CI is green[1] (the topmost patch
relates to another thread[2]), so I've I've checked the patchset into
tarantool branch in tarantool/luajit and bumped a new version in master.

On 02.12.21, Mikhail Shishatskiy wrote:
> Patchset v2 with some adjustments based on previous patch series,
> and several fixes with improvements:
> 
> - Removed "change order of modules patch";
> - Changed order of patches so that patch with symtab enriching
>   works correctly straingt away, and not after applying "on the spot
>   demangling" patch;
> - Changed flag representing that object has been dumped to an epoch
>   counter to respect consequent memprof launches.
> 
> Issue: https://github.com/tarantool/tarantool/issues/5815
> Branch: https://github.com/tarantool/luajit/tree/shishqa/gh-5815-enrich-symtab-when-prototype-is-allocated-v2
> Tarantool branch: https://github.com/tarantool/tarantool/tree/shishqa/gh-5815-enrich-symtab-when-prototype-is-allocated
> 
> Mikhail Shishatskiy (3):
>   memprof: add symbol epochs
>   memprof: enrich symtab when meeting new prototype
>   memprof: substitute long proto names with aliases
> 
>  src/lj_bcread.c                               |  3 +
>  src/lj_memprof.c                              | 35 +++++++---
>  src/lj_memprof.h                              | 13 +++-
>  src/lj_obj.h                                  | 10 +++
>  src/lj_parse.c                                |  3 +
>  src/lj_state.c                                |  3 +
>  .../misclib-memprof-lapi.test.lua             | 55 ++++++++++++---
>  tools/memprof.lua                             |  1 +
>  tools/memprof/humanize.lua                    | 14 ++++
>  tools/memprof/parse.lua                       | 51 ++++++++------
>  tools/utils/symtab.lua                        | 68 ++++++++++++++-----
>  11 files changed, 196 insertions(+), 60 deletions(-)
> 
> -- 
> 2.33.1
> 

[1]: https://github.com/tarantool/luajit/commit/11ab4c4
[2]: https://lists.tarantool.org/tarantool-patches/20211208172207.80148-1-m.shishatskiy@tarantool.org/

-- 
Best regards,
IM