From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 649876ECC0; Tue, 12 Apr 2022 17:33:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 649876ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1649774032; bh=GAVldQrBzFswIpyEG3gTIFx0cqVsyBBX3uJvdi3NztY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GwQkTIC7ril8NjoaWGE/Ic/MZOu5X8AyG+b6O3K56WjvcljHcpnXsY6kcp9ODvVkC mwTmWrrdbMjdNL9f5nRd/+vAXrW67aItUX0mc55Hs3h5ODs2Ift7g2KATz1npbyxzJ sB/B4DSNR6dbxoNv9117U0L5k7LWOz1fZfeYhASs= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EE9BB6ECC0 for ; Tue, 12 Apr 2022 17:33:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EE9BB6ECC0 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1neHaQ-0006GB-17; Tue, 12 Apr 2022 17:33:42 +0300 Date: Tue, 12 Apr 2022 17:30:15 +0300 To: Mikhail Shishatskiy Message-ID: References: <20211202110329.664738-1-m.shishatskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211202110329.664738-1-m.shishatskiy@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD916C41472748AFA0408FA01488F86E1C20208C06BFEC1AAE200894C459B0CD1B9EC2199CD5084BE98BB020FBE2FC2505A0A1242F98822031C66F2506D529139D3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD2F2D6F6013FF7FC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE77BF46084C0059042EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BEBC5CAB6D411FFA67F763C25AAE066B9D1A9C74A43FD3AFECC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B8D940F9BB5DEEEE475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A52B054E04DA3AFFE84DBBC207944A3DF9147B45636F045560D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F0DFBB38B116E9C7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EE6683D9E546CC628D635EF5052D755FFD401AD7A608AA3802D051C80C5B681E2AF03DCCEAB185321D7E09C32AA3244C19AF2EFC7A0DC24AD72A41902F55E410F94338140B71B8EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGJUQSLYIeTIdhKH20E771w== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D65F4E5B846DA05A9005EC71F13E07F52BA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 0/3] memprof: enrich symtab when meeting new prototype X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Misha, Thanks for the series! I've fixed all vital comments by Sergey, and few critical issues I've found by myself, LGTM otherwise. CI is green[1] (the topmost patch relates to another thread[2]), so I've I've checked the patchset into tarantool branch in tarantool/luajit and bumped a new version in master. On 02.12.21, Mikhail Shishatskiy wrote: > Patchset v2 with some adjustments based on previous patch series, > and several fixes with improvements: > > - Removed "change order of modules patch"; > - Changed order of patches so that patch with symtab enriching > works correctly straingt away, and not after applying "on the spot > demangling" patch; > - Changed flag representing that object has been dumped to an epoch > counter to respect consequent memprof launches. > > Issue: https://github.com/tarantool/tarantool/issues/5815 > Branch: https://github.com/tarantool/luajit/tree/shishqa/gh-5815-enrich-symtab-when-prototype-is-allocated-v2 > Tarantool branch: https://github.com/tarantool/tarantool/tree/shishqa/gh-5815-enrich-symtab-when-prototype-is-allocated > > Mikhail Shishatskiy (3): > memprof: add symbol epochs > memprof: enrich symtab when meeting new prototype > memprof: substitute long proto names with aliases > > src/lj_bcread.c | 3 + > src/lj_memprof.c | 35 +++++++--- > src/lj_memprof.h | 13 +++- > src/lj_obj.h | 10 +++ > src/lj_parse.c | 3 + > src/lj_state.c | 3 + > .../misclib-memprof-lapi.test.lua | 55 ++++++++++++--- > tools/memprof.lua | 1 + > tools/memprof/humanize.lua | 14 ++++ > tools/memprof/parse.lua | 51 ++++++++------ > tools/utils/symtab.lua | 68 ++++++++++++++----- > 11 files changed, 196 insertions(+), 60 deletions(-) > > -- > 2.33.1 > [1]: https://github.com/tarantool/luajit/commit/11ab4c4 [2]: https://lists.tarantool.org/tarantool-patches/20211208172207.80148-1-m.shishatskiy@tarantool.org/ -- Best regards, IM