From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: Maxim Kokryashkin <max.kokryashkin@gmail.com>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio Date: Wed, 16 Feb 2022 13:37:53 +0300 [thread overview] Message-ID: <YgzUAbCXowsYGJKh@tarantool.org> (raw) In-Reply-To: <YbtVebl5/148xMga@root> Sergey, On 16.12.21, Sergey Kaplun wrote: > Hi, Maxim! > > Thanks for the fixes! > > LGTM, except a few nits below. > > On 13.10.21, Maxim Kokryashkin wrote: > > Version and status are printed in stdout instead stderr > > since LuaJIT-2.0.0-beta11 (as it is not an error message). This behavior > > is the same as in Lua 5.2, so necessary changes in tests can be > > adapted from PUC-Rio Lua 5.2 test suite. > > > > However, those tests are disabled for Tarantool since its interactive > > shell doesn't support '=' at the beginning of statements. > > Here is an example: > > OK, so maybe we should create a ticket for that (and _PROMPT feature)? > At least to mention it and wait for thumbs up. > Igor, thoughts? I guess this is not an obligatory feature, since nobody claims Tarantool console should provide the similar interfaces LuaJIT does. IMHO, the best solution for this would be LuaJIT compatibility flag for Tarantool or its console, but I see no demand for this. So, it's up to you to file a ticket or not. > <snipped> > > -- > Best regards, > Sergey Kaplun -- Best regards, IM
next prev parent reply other threads:[~2022-02-16 10:41 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-24 13:58 [Tarantool-patches] [PATCH luajit] " Maxim Kokryashkin via Tarantool-patches 2021-09-24 14:34 ` Максим Корякшин via Tarantool-patches 2021-10-08 8:58 ` Sergey Kaplun via Tarantool-patches 2021-10-13 15:55 ` [Tarantool-patches] [PATCH luajit v2] " Maxim Kokryashkin via Tarantool-patches 2021-12-16 15:04 ` Sergey Kaplun via Tarantool-patches 2022-01-21 11:41 ` Максим Корякшин via Tarantool-patches 2022-02-16 10:37 ` Igor Munkin via Tarantool-patches 2022-02-16 10:37 ` Igor Munkin via Tarantool-patches [this message] 2022-02-17 12:01 ` Maxim Kokryashkin via Tarantool-patches 2022-02-16 10:37 ` Igor Munkin via Tarantool-patches 2021-10-08 8:54 ` [Tarantool-patches] [PATCH luajit] " Sergey Kaplun via Tarantool-patches 2022-02-17 16:38 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YgzUAbCXowsYGJKh@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox