From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8A3F26E454; Wed, 16 Feb 2022 13:41:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8A3F26E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1645008100; bh=hrTFoXLAN2/0XuL6hdzigLHaTRaNPymPX+yD9/D1vWU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ipeBsUrecAqbKIemdHx5oRgCeUng77tGKIvyiyptRqC2+DnAZ60a8QBLkE04EKrZH KHoWufdw+cM9rh7Trmu8adiMm3RKqDBrXAlLfHszE7/rlTKfmDRnP+eMe62Z12ERIe kXtI9eeV9w+LQbA+lbj2L8dDlNHu6kwADEsF/HCU= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C87146E454 for ; Wed, 16 Feb 2022 13:41:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C87146E454 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1nKHkD-0006FM-NX; Wed, 16 Feb 2022 13:41:10 +0300 Date: Wed, 16 Feb 2022 13:37:53 +0300 To: Sergey Kaplun Message-ID: References: <20211013155500.2639254-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD923F1B5F87BDC70E6CD687A88BADF9F55440F8199202B6F61182A05F538085040B8C2468BDD4D55DCE8816811A73C9E06747B1F76B07EA7BE099DD17C39C9E69F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7876E9C5582D2D91DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B5932F77F0041FFB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88C23902BC0412F99FFDA48C15D272D18117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D0C9BB9AE6BD5D69089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5DF6D558BE212F44FD89893E0B83C81F5682ABFBFD3B2AE9ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754D8E939D8DBE9AFC410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C6EC1BD9807109D26BCEA85B0A94E9255DB0FF4A73B4D94D8D07ED03F85BB02760AF6F8D07A23C9D1D7E09C32AA3244CE226842194AEAAC7EB8E1843D02C57FE30452B15D76AEC148D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5x0cJQaqqfrBgkeeTmkVvg== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D68C0E3F12A2618F1B448B14BC7922CADAA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 16.12.21, Sergey Kaplun wrote: > Hi, Maxim! > > Thanks for the fixes! > > LGTM, except a few nits below. > > On 13.10.21, Maxim Kokryashkin wrote: > > Version and status are printed in stdout instead stderr > > since LuaJIT-2.0.0-beta11 (as it is not an error message). This behavior > > is the same as in Lua 5.2, so necessary changes in tests can be > > adapted from PUC-Rio Lua 5.2 test suite. > > > > However, those tests are disabled for Tarantool since its interactive > > shell doesn't support '=' at the beginning of statements. > > Here is an example: > > OK, so maybe we should create a ticket for that (and _PROMPT feature)? > At least to mention it and wait for thumbs up. > Igor, thoughts? I guess this is not an obligatory feature, since nobody claims Tarantool console should provide the similar interfaces LuaJIT does. IMHO, the best solution for this would be LuaJIT compatibility flag for Tarantool or its console, but I see no demand for this. So, it's up to you to file a ticket or not. > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM