From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio Date: Wed, 16 Feb 2022 13:37:19 +0300 [thread overview] Message-ID: <YgzT36//RpP8CurO@tarantool.org> (raw) In-Reply-To: <20211013155500.2639254-1-m.kokryashkin@tarantool.org> Max, LGTM, considering post-review fixes you've made as a result of Sergey reply, but still some nits are remaining. Please, consider one of them below; you can find several more in the reply to post-review fixes. On 13.10.21, Maxim Kokryashkin wrote: <snipped> > --- > Changes in v2: > - Fixed comments as per review by Sergey > - Disabled some tests for Tarantool > - Added link to CI jobs > > Issue: https://github.com/tarantool/tarantool/issues/5687 > Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5687-adapt-tests-output-PUC-Rio > CI: https://github.com/tarantool/tarantool/tree/fckxorg/gh-5687-adapt-disabled-tests-from-PUC-Rio > > test/PUC-Rio-Lua-5.1-tests/main.lua | 97 ++++++++++++++++++++--------- > 1 file changed, 66 insertions(+), 31 deletions(-) > > diff --git a/test/PUC-Rio-Lua-5.1-tests/main.lua b/test/PUC-Rio-Lua-5.1-tests/main.lua > index 07facc4c..38111560 100644 > --- a/test/PUC-Rio-Lua-5.1-tests/main.lua > +++ b/test/PUC-Rio-Lua-5.1-tests/main.lua > @@ -24,11 +24,33 @@ local prepfile = function (s, p) > assert(io.close()) > end > > -function checkout (s) > +-- Taken from PUC-Rio Lua 5.2 test suite. > +-- See comment for checkprogout(). > +function getoutput () > io.input(out) > local t = io.read("*a") > io.input():close() > assert(os.remove(out)) > + return t > +end > + > +-- Version and status are printed in stdout instead stderr since Typo: s/instead/instead of/. > +-- LuaJIT-2.0.0-beta11 (as it is not an error message). > +-- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > +-- (Print version and JIT status to stdout, not stderr.). > +-- This behavior is the same as in Lua 5.2. > +-- See also https://github.com/tarantool/tarantool/issues/5687. > +-- This function is adapted from PUC-Rio Lua 5.2 test suite. > +-- It is used for test commands with -i flag. <snipped> > -- > 2.33.0 > -- Best regards, IM
next prev parent reply other threads:[~2022-02-16 10:40 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-24 13:58 [Tarantool-patches] [PATCH luajit] " Maxim Kokryashkin via Tarantool-patches 2021-09-24 14:34 ` Максим Корякшин via Tarantool-patches 2021-10-08 8:58 ` Sergey Kaplun via Tarantool-patches 2021-10-13 15:55 ` [Tarantool-patches] [PATCH luajit v2] " Maxim Kokryashkin via Tarantool-patches 2021-12-16 15:04 ` Sergey Kaplun via Tarantool-patches 2022-01-21 11:41 ` Максим Корякшин via Tarantool-patches 2022-02-16 10:37 ` Igor Munkin via Tarantool-patches 2022-02-16 10:37 ` Igor Munkin via Tarantool-patches 2022-02-17 12:01 ` Maxim Kokryashkin via Tarantool-patches 2022-02-16 10:37 ` Igor Munkin via Tarantool-patches [this message] 2021-10-08 8:54 ` [Tarantool-patches] [PATCH luajit] " Sergey Kaplun via Tarantool-patches 2022-02-17 16:38 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YgzT36//RpP8CurO@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox