From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A1A1E6E454; Wed, 16 Feb 2022 13:40:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A1A1E6E454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1645008039; bh=O1VjCBxW/Wc24kLxZN4Z22kP/7LT2PAOOWOL6HluD9Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OSuhhRHttzsE37lTGOSs/357J+pE42x9YK0qnVvU6LYbAeYdYowjk18DWUhdqzXv6 dzB2ZMYsc7g6nveyAC1Pwi9Lkhyipo1Q30myKGIg/pduiN7DfOc8L/D7/5WXxWul0N jgjB5bz+OlmoXcE8SUwTxDnWJ1fCdcznKIa95MEI= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 46B726E454 for ; Wed, 16 Feb 2022 13:40:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 46B726E454 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1nKHjh-00064p-0p; Wed, 16 Feb 2022 13:40:37 +0300 Date: Wed, 16 Feb 2022 13:37:19 +0300 To: Maxim Kokryashkin Message-ID: References: <20211013155500.2639254-1-m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211013155500.2639254-1-m.kokryashkin@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD98523E388497A0048D2B9DFB1C43171BBA43E0EFFBA844798182A05F538085040D3ADF7CF3DD237F884D103B8B89F434C27A4A3BDA7FF7880AEE5476933E69077 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D6964C9E324ABA58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375D54B99ECAFA2F678638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C3EBA99128411E29D537829FC8450B9D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D0C9BB9AE6BD5D69089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 0D63561A33F958A5DD63A7E5D783F7998968F9880356E82338B31EC444F95D6CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75438CC92D4039F4E2410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347130F804358653A607B84CC24E14DDA40DEADE3516EF69224549087C968AAD3258ADE220788B4A8D1D7E09C32AA3244C3804BD634EC6B287C70599F43DBC99E88894E9C85370243E8D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5x0cJQaqqfoeggCo7gHscw== X-Mailru-Sender: 689FA8AB762F739339CABD9B3CA9A7D65183EB9C27917A44ED61453FB5699D49A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: adapt disabled tests from PUC-Rio X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, LGTM, considering post-review fixes you've made as a result of Sergey reply, but still some nits are remaining. Please, consider one of them below; you can find several more in the reply to post-review fixes. On 13.10.21, Maxim Kokryashkin wrote: > --- > Changes in v2: > - Fixed comments as per review by Sergey > - Disabled some tests for Tarantool > - Added link to CI jobs > > Issue: https://github.com/tarantool/tarantool/issues/5687 > Branch: https://github.com/tarantool/luajit/tree/fckxorg/gh-5687-adapt-tests-output-PUC-Rio > CI: https://github.com/tarantool/tarantool/tree/fckxorg/gh-5687-adapt-disabled-tests-from-PUC-Rio > > test/PUC-Rio-Lua-5.1-tests/main.lua | 97 ++++++++++++++++++++--------- > 1 file changed, 66 insertions(+), 31 deletions(-) > > diff --git a/test/PUC-Rio-Lua-5.1-tests/main.lua b/test/PUC-Rio-Lua-5.1-tests/main.lua > index 07facc4c..38111560 100644 > --- a/test/PUC-Rio-Lua-5.1-tests/main.lua > +++ b/test/PUC-Rio-Lua-5.1-tests/main.lua > @@ -24,11 +24,33 @@ local prepfile = function (s, p) > assert(io.close()) > end > > -function checkout (s) > +-- Taken from PUC-Rio Lua 5.2 test suite. > +-- See comment for checkprogout(). > +function getoutput () > io.input(out) > local t = io.read("*a") > io.input():close() > assert(os.remove(out)) > + return t > +end > + > +-- Version and status are printed in stdout instead stderr since Typo: s/instead/instead of/. > +-- LuaJIT-2.0.0-beta11 (as it is not an error message). > +-- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > +-- (Print version and JIT status to stdout, not stderr.). > +-- This behavior is the same as in Lua 5.2. > +-- See also https://github.com/tarantool/tarantool/issues/5687. > +-- This function is adapted from PUC-Rio Lua 5.2 test suite. > +-- It is used for test commands with -i flag. > -- > 2.33.0 > -- Best regards, IM