Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>,
	tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed
Date: Fri, 19 Mar 2021 00:31:14 +0300	[thread overview]
Message-ID: <YFPGos+wsvvTz5LL@grain> (raw)
In-Reply-To: <34718073-d3ec-87fb-3d75-302acca3484f@tarantool.org>

On Thu, Mar 18, 2021 at 09:54:12PM +0100, Vladislav Shpilevoy wrote:
> >>
> >> Then it should have 'replication_' prefix, not 'wal_'. Because
> >> it is ignored if replicas connect before the timeout expires.
> > 
> > Replication is one of the reason while main gamer is "wal"
> > here. In the series I sent recently I named it "wal_cleanup_delay".
> > In future we might introduce some topology detector as you've
> > been suggesting and better to not stick to "replication"
> > prefix I think.
> 
> The thing you said is just another argument for it having 'replication'
> prefix. Because topology also is not about WAL.

Topology is anoter _reason_ to defer wal cleanup, and there might
be other reasons unrelated to replications at all. On the other
hands I see what you mean and won't insist. Should I name it
replication_cleanup_delay then?

  reply	other threads:[~2021-03-18 21:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 18:57 Cyrill Gorcunov via Tarantool-patches
2021-03-17 18:59 ` Cyrill Gorcunov via Tarantool-patches
2021-03-17 21:23 ` Konstantin Osipov via Tarantool-patches
2021-03-17 21:53   ` Cyrill Gorcunov via Tarantool-patches
2021-03-18  5:18     ` Konstantin Osipov via Tarantool-patches
2021-03-18  7:41       ` Cyrill Gorcunov via Tarantool-patches
2021-03-18  7:51         ` Konstantin Osipov via Tarantool-patches
2021-03-18  7:56           ` Cyrill Gorcunov via Tarantool-patches
2021-03-18 20:36           ` Vladislav Shpilevoy via Tarantool-patches
2021-03-18 20:45             ` Cyrill Gorcunov via Tarantool-patches
2021-03-18 20:54               ` Vladislav Shpilevoy via Tarantool-patches
2021-03-18 21:31                 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-03-18 23:04                   ` Vladislav Shpilevoy via Tarantool-patches
2021-03-19  7:13                     ` Cyrill Gorcunov via Tarantool-patches
2021-03-19  8:00                     ` Konstantin Osipov via Tarantool-patches
2021-03-19  7:40             ` Konstantin Osipov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFPGos+wsvvTz5LL@grain \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=v.perepelitsa@corp.mail.ru \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox