From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>,
Mons Anderson <v.perepelitsa@corp.mail.ru>,
Serge Petrenko <sergepetrenko@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed
Date: Thu, 18 Mar 2021 21:36:33 +0100 [thread overview]
Message-ID: <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> (raw)
In-Reply-To: <20210318075127.GA4019@starling>
On 18.03.2021 08:51, Konstantin Osipov via Tarantool-patches wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [21/03/18 10:42]:
>> Good point, thanks! Kostya, lets clarify some moments:
>>
>> 1) We introduce "wal_keep_logs" option which defines
>> a timeout to kick the cleanup fiber.
>> 2) If node is anonymous replica we simply ignore this
>> option.
>> 3) If this option is set then we have a few subcases:
>> a) The `_cluster` space is not empty thus thus once
>> all replicas are subscribed _before_ the timeout
>> expired we trigger the cleanup fiber since it is
>> safe to process;
>> b) If replicas are not connected and timeout is
>> expired we kick the cleanup fiber;
>
> I mean this.
Then it should have 'replication_' prefix, not 'wal_'. Because
it is ignored if replicas connect before the timeout expires.
next prev parent reply other threads:[~2021-03-18 20:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 18:57 Cyrill Gorcunov via Tarantool-patches
2021-03-17 18:59 ` Cyrill Gorcunov via Tarantool-patches
2021-03-17 21:23 ` Konstantin Osipov via Tarantool-patches
2021-03-17 21:53 ` Cyrill Gorcunov via Tarantool-patches
2021-03-18 5:18 ` Konstantin Osipov via Tarantool-patches
2021-03-18 7:41 ` Cyrill Gorcunov via Tarantool-patches
2021-03-18 7:51 ` Konstantin Osipov via Tarantool-patches
2021-03-18 7:56 ` Cyrill Gorcunov via Tarantool-patches
2021-03-18 20:36 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-03-18 20:45 ` Cyrill Gorcunov via Tarantool-patches
2021-03-18 20:54 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-18 21:31 ` Cyrill Gorcunov via Tarantool-patches
2021-03-18 23:04 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-19 7:13 ` Cyrill Gorcunov via Tarantool-patches
2021-03-19 8:00 ` Konstantin Osipov via Tarantool-patches
2021-03-19 7:40 ` Konstantin Osipov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=kostja.osipov@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=v.perepelitsa@corp.mail.ru \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox