From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 75A086EC56; Thu, 18 Mar 2021 23:36:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 75A086EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616099798; bh=nQo1S5CKnG5RAUq6xpnyVCS+kSMPjlJHTYxZGlJUkxw=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=k8iQaZA9zoTjgD2ASaGBOZh5uP+/PD/622Vq8Js1IdLEN4No6a15DSQp90uzlWOyB 9x3Awfqvc6JkMQGUJ5lCBM3mSCVkU/jhAW9rfdUGFiDhHz5MFAA80eHAxMVUi3cj2z i9aJlVEFiswuRRdtoG6nySzw/N+sQXD7VTlmc7dM= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C7A6F6EC56 for ; Thu, 18 Mar 2021 23:36:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C7A6F6EC56 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lMzNj-0004W2-77; Thu, 18 Mar 2021 23:36:35 +0300 To: Konstantin Osipov , Cyrill Gorcunov , tml , Mons Anderson , Serge Petrenko , Kirill Yukhin References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> <20210318051812.GB224985@starling> <20210318075127.GA4019@starling> Message-ID: <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> Date: Thu, 18 Mar 2021 21:36:33 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210318075127.GA4019@starling> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-618D5548: 8DD8261714E55E088321140649C5EDD7ECE13F3785F0FF1B1FA5110E170B3D8D X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96485A7A9FC1318935A89AF0CDB68A1C65FFEA4E2B72DF156182A05F53808504007505972F70E7ECEBB2C374AC75DED713C5B84700AD6423B08366B0F5E397030 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F1942E6D70B4A2F0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375121C8F3070B83748638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CF89CA98302ED496F3EF55C06526ABCFEFC08F3BCF75EB648A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7BE1F02509D432EA69FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C314747542773C033F117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C224966D37212B2E9A769089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CC8BAF2118CBBB27043847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148F6B16E133A9586FB82623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20BB63DED767380FDF6E5C98D783532FCC6 X-C1DE0DAB: 0D63561A33F958A5002F76D43D5334AF1746A0FCBD7EE88E993EDF07E19C09B5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347215713CF3EEE9D1D68672E598EDADDD4192ACAE192E0490DF21B4A210AE47ED52A600E10DF58F0C1D7E09C32AA3244C67D461A96844078B86601ACD000BCA4CF94338140B71B8EE8D5DD81C2BAB7D1D X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBN5tWX4G0Zw+S+80GPc52Q== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638225E0A359FE25B2381B78BB7D4349DF9CC3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 18.03.2021 08:51, Konstantin Osipov via Tarantool-patches wrote: > * Cyrill Gorcunov [21/03/18 10:42]: >> Good point, thanks! Kostya, lets clarify some moments: >> >> 1) We introduce "wal_keep_logs" option which defines >> a timeout to kick the cleanup fiber. >> 2) If node is anonymous replica we simply ignore this >> option. >> 3) If this option is set then we have a few subcases: >> a) The `_cluster` space is not empty thus thus once >> all replicas are subscribed _before_ the timeout >> expired we trigger the cleanup fiber since it is >> safe to process; >> b) If replicas are not connected and timeout is >> expired we kick the cleanup fiber; > > I mean this. Then it should have 'replication_' prefix, not 'wal_'. Because it is ignored if replicas connect before the timeout expires.