From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4397A6EC56; Fri, 19 Mar 2021 00:31:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4397A6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616103078; bh=goMxGVxIwEE1kLy/ZBLxwwhnYN4YGkwr+IjlmGn8hQI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Dz5AGi/GwlmVsPvw4WCEiwEoGLbV2mlq6lkizMD+BSGLFOye1KAE0fAdPXSHSQI4R vZPfp8o264egCIyjGAB/1kXMjJesxM7BJ7j+ywT32PYhl5MbwQw1qj/FYw2tspN9rx bYecZ1cEdfBWYW/99dev4Tk5pEwsWPSTG7+AU070= Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 967756EC56 for ; Fri, 19 Mar 2021 00:31:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 967756EC56 Received: by mail-lf1-f46.google.com with SMTP id j11so6828781lfg.12 for ; Thu, 18 Mar 2021 14:31:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UL57OpCt7QnfabUf3OTcfdAkfHS9Ph2HvcLFjzMyXXo=; b=cV8Lk/C4JoI7Wj2ZY6EfOC/2VCfOHrM6ODS49ghLmJ+WysE5iUnoHp5prpQZpeZqLF urGA5hv49GmeWVulSzhFqOSEcf0pb7iE0PQMAMsuX1dVbuEBukXKrXTXg4pt6P5Co9EI AaltGpKiQa1bnGcPVLF8qiLllBBZVu5mFSBo4epcbaVtQPLAQOCEQWGUJwBe2xD8ajqc XQri2UOhZzBeA3nWaW+gXATULoxyDxvubDkwqY8pKFmE375mOb+pRZLUpkx5hiqiQP7e J6t/XROwAlmC1NDwAvArrZfkl9Xmm8RxMahNZqEb9j0AH65WCZRrxOJ5zeffhMGl5SW0 fn7g== X-Gm-Message-State: AOAM532olkDqZvgWVFIpi6tmdopKGvj9i8TB+lD0iLvlflyib8RJR20K tGua4MeazHd1unQtMkL3RXI= X-Google-Smtp-Source: ABdhPJyec4Q43yiZzKXZyGsgnXArF8kGR6dHuG/cojcxGfa9ohXOQ6Je2LTICGE/xwouRxDeGoabKg== X-Received: by 2002:a05:6512:3a8f:: with SMTP id q15mr6218803lfu.389.1616103076186; Thu, 18 Mar 2021 14:31:16 -0700 (PDT) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id v9sm370232lfd.195.2021.03.18.14.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 14:31:15 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 2BEEA560133; Fri, 19 Mar 2021 00:31:14 +0300 (MSK) Date: Fri, 19 Mar 2021 00:31:14 +0300 To: Vladislav Shpilevoy Message-ID: References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> <20210318051812.GB224985@starling> <20210318075127.GA4019@starling> <2cab3281-33f8-7a59-384b-41364501e57d@tarantool.org> <34718073-d3ec-87fb-3d75-302acca3484f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34718073-d3ec-87fb-3d75-302acca3484f@tarantool.org> User-Agent: Mutt/2.0.5 (2021-01-21) Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Mons Anderson , tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Thu, Mar 18, 2021 at 09:54:12PM +0100, Vladislav Shpilevoy wrote: > >> > >> Then it should have 'replication_' prefix, not 'wal_'. Because > >> it is ignored if replicas connect before the timeout expires. > > > > Replication is one of the reason while main gamer is "wal" > > here. In the series I sent recently I named it "wal_cleanup_delay". > > In future we might introduce some topology detector as you've > > been suggesting and better to not stick to "replication" > > prefix I think. > > The thing you said is just another argument for it having 'replication' > prefix. Because topology also is not about WAL. Topology is anoter _reason_ to defer wal cleanup, and there might be other reasons unrelated to replications at all. On the other hands I see what you mean and won't insist. Should I name it replication_cleanup_delay then?