From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maksim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v4 5/8] OSX/ARM64: Disable unwind info. Date: Thu, 24 Nov 2022 14:41:00 +0300 [thread overview] Message-ID: <Y39YTKrsQ8e/L9Ia@root> (raw) In-Reply-To: <20221028092638.11506-6-max.kokryashkin@gmail.com> Hi, Maksim! Thanks for the patch! LGTM, with a single nit regarding the commit message. On 28.10.22, Maksim Kokryashkin wrote: > From: Mike Pall <mike> > > See #698. > > (cherry picked from commit 78350a2565e1cf1102bcd25be406f02953d4dd3b) > > External unwinding support is already disabled for OSX on ARM64 Typo: s/on ARM64 platform/on the ARM64 platform/ > platform so there is no point in generation of incorrect unwind > info for it. This patch disables that generation for the commit > history match, and it will be re-enabled in the next commit, > which contains the fix for the issue. > > Maxim Kokryashkin: > * added the description for the problem > > Needed for tarantool/tarantool#6096 > Part of tarantool/tarantool#7230 > --- > src/vm_arm64.dasc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/vm_arm64.dasc b/src/vm_arm64.dasc > index ad57bca3..ccfa72bd 100644 > --- a/src/vm_arm64.dasc > +++ b/src/vm_arm64.dasc <snipped> > -- > 2.37.0 (Apple Git-136) > -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2022-11-24 11:44 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20221028092638.11506-1-max.kokryashkin@gmail.com> [not found] ` <20221028092638.11506-5-max.kokryashkin@gmail.com> 2022-11-24 11:37 ` [Tarantool-patches] [PATCH luajit v4 4/8] ARM64: Reorder interpreter stack frame and fix unwinding Sergey Kaplun via Tarantool-patches 2022-11-30 13:04 ` Maxim Kokryashkin via Tarantool-patches 2022-12-05 21:42 ` sergos via Tarantool-patches [not found] ` <20221028092638.11506-6-max.kokryashkin@gmail.com> 2022-11-24 11:41 ` Sergey Kaplun via Tarantool-patches [this message] 2022-11-30 13:05 ` [Tarantool-patches] [PATCH luajit v4 5/8] OSX/ARM64: Disable unwind info Maxim Kokryashkin via Tarantool-patches 2022-12-05 21:43 ` sergos via Tarantool-patches [not found] ` <20221028092638.11506-8-max.kokryashkin@gmail.com> 2022-11-24 11:56 ` [Tarantool-patches] [PATCH luajit v4 7/8] Fix build with busybox grep Sergey Kaplun via Tarantool-patches 2022-11-30 13:06 ` Maxim Kokryashkin via Tarantool-patches 2022-12-05 21:51 ` sergos via Tarantool-patches [not found] ` <20221028092638.11506-2-max.kokryashkin@gmail.com> 2022-12-05 16:01 ` [Tarantool-patches] [PATCH luajit v4 1/8] Cleanup and enable external unwinding for more platforms sergos via Tarantool-patches [not found] ` <20221028092638.11506-3-max.kokryashkin@gmail.com> 2022-12-05 16:06 ` [Tarantool-patches] [PATCH luajit v4 2/8] OSX: Fix build by hardcoding external frame unwinding sergos via Tarantool-patches [not found] ` <20221028092638.11506-4-max.kokryashkin@gmail.com> 2022-12-05 16:11 ` [Tarantool-patches] [PATCH luajit v4 3/8] OSX/ARM64: Disable external unwinding for now sergos via Tarantool-patches [not found] ` <20221028092638.11506-7-max.kokryashkin@gmail.com> 2022-11-24 11:49 ` [Tarantool-patches] [PATCH luajit v4 6/8] BSD: Fix build with BSD grep Sergey Kaplun via Tarantool-patches 2022-11-30 13:05 ` Maxim Kokryashkin via Tarantool-patches 2022-12-05 21:46 ` sergos via Tarantool-patches [not found] ` <20221028092638.11506-9-max.kokryashkin@gmail.com> 2022-11-24 13:10 ` [Tarantool-patches] [PATCH luajit v4 8/8] OSX/ARM64: Fix external unwinding Sergey Kaplun via Tarantool-patches 2022-11-30 13:21 ` Maxim Kokryashkin via Tarantool-patches 2022-12-01 8:52 ` Sergey Kaplun via Tarantool-patches 2022-12-01 12:28 ` Sergey Kaplun via Tarantool-patches 2022-12-06 5:58 ` sergos via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y39YTKrsQ8e/L9Ia@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v4 5/8] OSX/ARM64: Disable unwind info.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox