Re: [Tarantool-patches] [PATCH luajit v4 6/8] BSD: Fix build with BSD grep.

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]


Hi!
Thanks for the review!
  
>Четверг, 24 ноября 2022, 14:52 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:
> 
>Hi, Maksim!
>
>Thanks for the patch!
>
>LGTM, with a single nit below.
>
>On 28.10.22, Maksim Kokryashkin wrote:
>> From: Mike Pall <mike>
>>
>> Thanks to carlocab.
>>
>> (cherry picked from commit b9d523965b3f55b19345a1ed1ebc92e431747ce1)
>>
>> The `-U` option makes grep process the temporary binary file as
>> a binary instead of text, meaning that its contents are passed
>
>I suggest to clarify this part like the following:
>| instead of as ASCII text with `-a` option set
Fixed.
>
>> to grep verbatim.
>>
>> Maxim Kokryashkin:
>> * added the description for the problem and updated the CMake
>>
>> Needed for tarantool/tarantool#6096
>> Part of tarantool/tarantool#7230
>> ---
>> cmake/SetTargetFlags.cmake | 2 +-
>> src/Makefile.original | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake
>> index d99e1f9a..943a3152 100644
>> --- a/cmake/SetTargetFlags.cmake
>> +++ b/cmake/SetTargetFlags.cmake
>
><snipped>
>
>> diff --git a/src/Makefile.original b/src/Makefile.original
>> index 5826a56a..4d7cda3e 100644
>> --- a/src/Makefile.original
>> +++ b/src/Makefile.original
>
><snipped>
>
>> --
>> 2.37.0 (Apple Git-136)
>>
>
>--
>Best regards,
>Sergey Kaplun
--
Best regards,
Maxim Kokryashkin
 

[-- Attachment #2: Type: text/html, Size: 2144 bytes --]