From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0B4D47B11C; Thu, 24 Nov 2022 14:44:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0B4D47B11C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1669290252; bh=jdaxyuh1QGeXARvErE9nIltYVKJqkuF7firWIGK0QPE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GQjZZrUO+WeNRY8AI4as3UipjF5X4/Wy14TrkmrZ5dEMKine5u9yzoBapmbQtkjfV zIh6gyTpr90fEsvT0ycmoMc4GEe7nsmlx37imIQ6mRYlFf0IMNmSLKnco+WVL4kP5k MXTsH5ri4cItFD12XJ3XudQ+SfwlhhdQSukRAW2Y= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1BDB97B11C for ; Thu, 24 Nov 2022 14:44:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1BDB97B11C Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1oyAeI-0008JC-7L; Thu, 24 Nov 2022 14:44:10 +0300 Date: Thu, 24 Nov 2022 14:41:00 +0300 To: Maksim Kokryashkin Message-ID: References: <20221028092638.11506-1-max.kokryashkin@gmail.com> <20221028092638.11506-6-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221028092638.11506-6-max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9D4445358DD2C13E243E0EE258B3A918BCFE4CB1EFE183899182A05F5380850405124826D2AC088E3544023769F5D7B3852D297CD455AE1A57F6B8365E363AA15 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063770519A3AF4A224F58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D880BCF0FD36201734EC1F8EE7F110DC4B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3733B5EC72352B9FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735200AC5B80A05675ACD28451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE042285CD7A5C321F81C726BC2B329815D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D889735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006373BA04B6A498D0BA4731C566533BA786AA5CC5B56E945C8DA X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A4C04F5DECA7EE9C7D252FC89829E5579E83C0271E8372E585A8199E8AB1931ED7D2D6AE6738A701D7E09C32AA3244C318D11A8964E329FAD044813A6FD44F224AF4FAF06DA24FD927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZo+qSBrEvGTtlzjZNJc5lw== X-Mailru-Sender: F6248FDC0389C51188CF133EE5DC084FD5891B6BEACD827DAAFCEEF8DF11DF9CB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 5/8] OSX/ARM64: Disable unwind info. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maksim! Thanks for the patch! LGTM, with a single nit regarding the commit message. On 28.10.22, Maksim Kokryashkin wrote: > From: Mike Pall > > See #698. > > (cherry picked from commit 78350a2565e1cf1102bcd25be406f02953d4dd3b) > > External unwinding support is already disabled for OSX on ARM64 Typo: s/on ARM64 platform/on the ARM64 platform/ > platform so there is no point in generation of incorrect unwind > info for it. This patch disables that generation for the commit > history match, and it will be re-enabled in the next commit, > which contains the fix for the issue. > > Maxim Kokryashkin: > * added the description for the problem > > Needed for tarantool/tarantool#6096 > Part of tarantool/tarantool#7230 > --- > src/vm_arm64.dasc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/vm_arm64.dasc b/src/vm_arm64.dasc > index ad57bca3..ccfa72bd 100644 > --- a/src/vm_arm64.dasc > +++ b/src/vm_arm64.dasc > -- > 2.37.0 (Apple Git-136) > -- Best regards, Sergey Kaplun