Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix
Date: Mon, 13 Feb 2023 12:37:10 +0300	[thread overview]
Message-ID: <Y+oExuDiEMaErjYP@root> (raw)
In-Reply-To: <Y+oEH+nfoifcyRc0@tarantool.org>

Hi, Igor!

Thanks for the review!

On 13.02.23, Igor Munkin wrote:
> Sergey,
> Thanks for your patch! The only change I suggest is splitting this one
> into two separate patches: one for the matrix and another for CHECKHOOK
> job. Otherwise, LGTM.

Done! You can see it in the following ML thread [1].
Branch is force pushed.

> -- 
> Best regards,
> IM

[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2023-February/027399.html

Best regards,
Sergey Kaplun

      reply	other threads:[~2023-02-13  9:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06  7:17 Sergey Kaplun via Tarantool-patches
2023-02-06 11:00 ` Maxim Kokryashkin via Tarantool-patches
2023-02-13  9:34 ` Igor Munkin via Tarantool-patches
2023-02-13  9:37   ` Sergey Kaplun via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+oExuDiEMaErjYP@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox