From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix
Date: Mon, 06 Feb 2023 14:00:01 +0300 [thread overview]
Message-ID: <1675681201.692525029@f113.i.mail.ru> (raw)
In-Reply-To: <20230206071710.5191-1-skaplun@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 2045 bytes --]
Hi, Sergey!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
>
>>This commit adds the build with the aforementioned option to test
>>on x86_64 and arm64 architectures to exotic build matrix.
>>---
>>
>>Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-ci-checkhook
>>Workflow example: https://github.com/tarantool/luajit/actions/runs/4101136217
>>
>> .github/workflows/exotic-builds-testing.yml | 15 +++++++++++----
>> 1 file changed, 11 insertions(+), 4 deletions(-)
>>
>>diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml
>>index cd0c14d7..aaf4f9f6 100644
>>--- a/.github/workflows/exotic-builds-testing.yml
>>+++ b/.github/workflows/exotic-builds-testing.yml
>>@@ -29,13 +29,14 @@ concurrency:
>> cancel-in-progress: true
>>
>> jobs:
>>- test-x86_64-exotic:
>>+ test-exotic:
>> strategy:
>> fail-fast: false
>> matrix:
>> BUILDTYPE: [Debug, Release]
>>+ ARCH: [ARM64, x86_64]
>> GC64: [ON, OFF]
>>- FLAVOR: [dualnum]
>>+ FLAVOR: [dualnum, checkhook]
>> include:
>> - BUILDTYPE: Debug
>> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
>>@@ -43,10 +44,16 @@ jobs:
>> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
>> - FLAVOR: dualnum
>> FLAVORFLAGS: -DLUAJIT_NUMMODE=2
>>- runs-on: [self-hosted, regular, Linux, x86_64]
>>+ - FLAVOR: checkhook
>>+ FLAVORFLAGS: -DLUAJIT_ENABLE_CHECKHOOK=ON
>>+ exclude:
>>+ # DUALNUM is default for ARM64, no need for additional testing.
>>+ - FLAVOR: dualnum
>>+ ARCH: ARM64
>>+ runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}']
>> name: >
>> LuaJIT ${{ matrix.FLAVOR }}
>>- (Linux/x86_64)
>>+ (Linux/${{ matrix.ARCH }})
>> ${{ matrix.BUILDTYPE }}
>> GC64:${{ matrix.GC64 }}
>> steps:
>>--
>>2.34.1
>
[-- Attachment #2: Type: text/html, Size: 3405 bytes --]
next prev parent reply other threads:[~2023-02-06 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 7:17 Sergey Kaplun via Tarantool-patches
2023-02-06 11:00 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-02-13 9:34 ` Igor Munkin via Tarantool-patches
2023-02-13 9:37 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1675681201.692525029@f113.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox