From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5FD02255EB1; Mon, 13 Feb 2023 12:40:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5FD02255EB1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1676281244; bh=eOzqJeRbNhiOrRTOb+ByJhMN7HplUMC071TxIuMEQIc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WHXl8SkQr8nRecYZl+r88ooXJgccoVxb3jWb+6y/o22Tc+JYPbsoZ8fluY+qAGfUm 5S9PverDmd1ODkxIWGh2FrJGtL6Y3wKVP7k+2ghduAQy62OzHPWICA9JMJkQCMl17i TFzWt3xhzQbPb1t6f+t5YH6beT4mqP3DkQ1M21kE= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 38FB6255EB1 for ; Mon, 13 Feb 2023 12:40:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 38FB6255EB1 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pRVKE-0008Bn-Da; Mon, 13 Feb 2023 12:40:42 +0300 Date: Mon, 13 Feb 2023 12:37:10 +0300 To: Igor Munkin Message-ID: References: <20230206071710.5191-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D919194CF4FC6604346A7C8E82EB5D99FA3505363B50C6B2182A05F53808504094F16E1256B75375D006BF4A46E4DF43F24781EF3D9A61A18E135430C465690A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063715F166F2542EEE4C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F5D7E9BBE6A85D03650F57B05C057130117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC972D20C7389F068BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FEC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67393CE827C55B5F775ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34CC972AA0E2E780C4344AB9607762F16A7965EAEA95C84D592A97303C0E63B188163F1968A0C76C5F1D7E09C32AA3244C8D990F3CB7631D52232243A157143DF9E3D93501275E802F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojukIRxTCPvFv6R1l4s8Qxtw== X-DA7885C5: AA30AD4B1E04159B1F4BE5CE9051967A40693AB3C4429B3CA78C0028D2ED559A262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF505ADE5CC3469FD6D21C281E6FBD13DBB0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: add LUAJIT_ENABLE_CHECKHOOK for exotic matrix X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the review! On 13.02.23, Igor Munkin wrote: > Sergey, > > Thanks for your patch! The only change I suggest is splitting this one > into two separate patches: one for the matrix and another for CHECKHOOK > job. Otherwise, LGTM. Done! You can see it in the following ML thread [1]. Branch is force pushed. > > -- > Best regards, > IM [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2023-February/027399.html -- Best regards, Sergey Kaplun