From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 2/4] feedback_daemon: rename `send_test` to `send` Date: Fri, 2 Apr 2021 17:58:01 +0300 [thread overview] Message-ID: <8f855571e93621a969cb76a2ab6f3e2f7499d7ad.1617375300.git.sergepetrenko@tarantool.org> (raw) In-Reply-To: <cover.1617375300.git.sergepetrenko@tarantool.org> feedback_daemon.send() will come in handy once we implement triggers to dispatch feedback after some events, for example, right on initial instance configuration. So, it's not a testing method anymore, hence the new name. Part of #5750 --- src/box/lua/feedback_daemon.lua | 2 +- test/box-tap/feedback_daemon.test.lua | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 8820bcde5..d00eedf39 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -412,7 +412,7 @@ setmetatable(daemon, { reload = function() reload(daemon) end, - send_test = function() + send = function() if daemon.control ~= nil then daemon.control:put("send") end diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua index e1c450d2b..3d6bf1d9b 100755 --- a/test/box-tap/feedback_daemon.test.lua +++ b/test/box-tap/feedback_daemon.test.lua @@ -93,28 +93,28 @@ feedback_reset() errinj.set("ERRINJ_HTTPC", false) check('feedback received after errinj') -daemon.send_test() +daemon.send() check("feedback received after explicit sending") box.cfg{feedback_enabled = false} feedback_reset() -daemon.send_test() +daemon.send() test:ok(feedback_count == 0, "no feedback after disabling") box.cfg{feedback_enabled = true} -daemon.send_test() +daemon.send() check("feedback after start") daemon.stop() feedback_reset() -daemon.send_test() +daemon.send() test:ok(feedback_count == 0, "no feedback after stop") daemon.start() -daemon.send_test() +daemon.send() check("feedback after start") -daemon.send_test() -check("feedback after feedback send_test") +daemon.send() +check("feedback after feedback send") daemon.stop() @@ -136,7 +136,7 @@ server:close() -- check it does not fail without server daemon = box.internal.feedback_daemon daemon.start() -daemon.send_test() +daemon.send() daemon.stop() -- -- 2.24.3 (Apple Git-128)
next prev parent reply other threads:[~2021-04-02 14:59 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-02 14:57 [Tarantool-patches] [PATCH 0/4] send feedback on tarantool start Serge Petrenko via Tarantool-patches 2021-04-02 14:58 ` [Tarantool-patches] [PATCH 1/4] feedback_daemon: include server uptime in the report Serge Petrenko via Tarantool-patches 2021-04-02 14:58 ` Serge Petrenko via Tarantool-patches [this message] 2021-04-02 14:58 ` [Tarantool-patches] [PATCH 3/4] feedback_daemon: send feedback on server start Serge Petrenko via Tarantool-patches 2021-04-05 13:18 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-05 14:05 ` Serge Petrenko via Tarantool-patches 2021-04-05 16:11 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-08 13:41 ` Serge Petrenko via Tarantool-patches 2021-04-02 14:58 ` [Tarantool-patches] [PATCH 4/4] feedback_daemon: generate report right before sending Serge Petrenko via Tarantool-patches 2021-04-05 14:03 ` Serge Petrenko via Tarantool-patches 2021-04-05 16:23 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-06 8:18 ` Serge Petrenko via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8f855571e93621a969cb76a2ab6f3e2f7499d7ad.1617375300.git.sergepetrenko@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2/4] feedback_daemon: rename `send_test` to `send`' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox