From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 4/4] feedback_daemon: generate report right before sending Date: Fri, 2 Apr 2021 17:58:03 +0300 [thread overview] Message-ID: <44f4b260e0ac435fe78282c1f6f4607159914935.1617375300.git.sergepetrenko@tarantool.org> (raw) In-Reply-To: <cover.1617375300.git.sergepetrenko@tarantool.org> Feedback daemon used to generate report before waiting (for an hour by default) until it's time to send it. Better actualize the reports and generate them right when it's time to send them. Follow-up #5750 --- src/box/lua/feedback_daemon.lua | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 2ce768642..0aab189b6 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -327,12 +327,13 @@ local function feedback_loop(self) fiber.name(PREFIX, { truncate = true }) while true do - local feedback = self:generate_feedback() local msg = self.control:get(self.interval) -- if msg == "send" then we simply send feedback if msg == "stop" then break - elseif feedback ~= nil then + end + local feedback = self:generate_feedback() + if feedback ~= nil then pcall(http.post, self.host, json.encode(feedback), {timeout=1}) end end -- 2.24.3 (Apple Git-128)
next prev parent reply other threads:[~2021-04-02 15:00 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-02 14:57 [Tarantool-patches] [PATCH 0/4] send feedback on tarantool start Serge Petrenko via Tarantool-patches 2021-04-02 14:58 ` [Tarantool-patches] [PATCH 1/4] feedback_daemon: include server uptime in the report Serge Petrenko via Tarantool-patches 2021-04-02 14:58 ` [Tarantool-patches] [PATCH 2/4] feedback_daemon: rename `send_test` to `send` Serge Petrenko via Tarantool-patches 2021-04-02 14:58 ` [Tarantool-patches] [PATCH 3/4] feedback_daemon: send feedback on server start Serge Petrenko via Tarantool-patches 2021-04-05 13:18 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-05 14:05 ` Serge Petrenko via Tarantool-patches 2021-04-05 16:11 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-08 13:41 ` Serge Petrenko via Tarantool-patches 2021-04-02 14:58 ` Serge Petrenko via Tarantool-patches [this message] 2021-04-05 14:03 ` [Tarantool-patches] [PATCH 4/4] feedback_daemon: generate report right before sending Serge Petrenko via Tarantool-patches 2021-04-05 16:23 ` Vladislav Shpilevoy via Tarantool-patches 2021-04-06 8:18 ` Serge Petrenko via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=44f4b260e0ac435fe78282c1f6f4607159914935.1617375300.git.sergepetrenko@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 4/4] feedback_daemon: generate report right before sending' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox