From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D19256EC5D; Fri, 2 Apr 2021 17:59:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D19256EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617375561; bh=iBNioEeciuzCwLBbVuOcGzl7/nL0nm+CU3zz1QAQyjE=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=czP5lXBJB3vNhYyLkpn7wH9IFG8lfYuzG4UYlwTuuSmL0mSXzLUfyImdqs3KfZ4Mj l9Lx/f1cz9xvNRB0e9DOBX6BivYzvZTanTYxgO+/bJlIoJswsY5XtVBWSrYODGCTVK 4lyW7MRm3G3IZu4q3ag9NWD+/rQi+UrXpEvph3tg= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 565CE6EC5E for ; Fri, 2 Apr 2021 17:58:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 565CE6EC5E Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1lSLFd-0006jR-K1; Fri, 02 Apr 2021 17:58:21 +0300 To: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Date: Fri, 2 Apr 2021 17:58:01 +0300 Message-Id: <8f855571e93621a969cb76a2ab6f3e2f7499d7ad.1617375300.git.sergepetrenko@tarantool.org> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA70927CAA5B950F38D9F182A05F538085040808A14EFCC433AF6A4AD39FCF240C3ABF483002BA4FB0B59337D26EA2DAA2D9A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7081BBE264C6D7F42EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371E4BC0E00C009995EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664518AE90F1FD46BBFDEDA1C77A26F1496C2BAAF360FF83719389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07C37DE3F426B52F18941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6F7EC8CC465A83DA3CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249DD9E4B684926F50376E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B3FC74F06264136033AA81AA40904B5D9DBF02ECDB25306B2201CA6A4E26CD07C3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B58781B77DE60D36C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46DF017E5E59F116FF0355D89D7DBCDD132 X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C7B5A45DDF210A4CFEE7EB662357B3F3BBF544C47223C5FC09C2B6934AE262D3EE7EAB7254005DCED7532B743992DF240BDC6A1CF3F042BAD6DF99611D93F60EF0417BEADF48D1460699F904B3F4130E343918A1A30D5E7FCCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3419891600CCEF4607D5BE87EFDEE76F7CA4A915BD9032BFA604A7DC093E368A4784816634CF9845681D7E09C32AA3244C7DDFBCEFD539A20AC83539FB949DE4AA33C9DC155518937F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbL9S8ysBdXhDmqlpxPgE9zDAw/QOrR9Z X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F81968ACF4E54473F8861007885E5D1690D0BDB79D865F2E0F424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: [Tarantool-patches] [PATCH 2/4] feedback_daemon: rename `send_test` to `send` X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" feedback_daemon.send() will come in handy once we implement triggers to dispatch feedback after some events, for example, right on initial instance configuration. So, it's not a testing method anymore, hence the new name. Part of #5750 --- src/box/lua/feedback_daemon.lua | 2 +- test/box-tap/feedback_daemon.test.lua | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 8820bcde5..d00eedf39 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -412,7 +412,7 @@ setmetatable(daemon, { reload = function() reload(daemon) end, - send_test = function() + send = function() if daemon.control ~= nil then daemon.control:put("send") end diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua index e1c450d2b..3d6bf1d9b 100755 --- a/test/box-tap/feedback_daemon.test.lua +++ b/test/box-tap/feedback_daemon.test.lua @@ -93,28 +93,28 @@ feedback_reset() errinj.set("ERRINJ_HTTPC", false) check('feedback received after errinj') -daemon.send_test() +daemon.send() check("feedback received after explicit sending") box.cfg{feedback_enabled = false} feedback_reset() -daemon.send_test() +daemon.send() test:ok(feedback_count == 0, "no feedback after disabling") box.cfg{feedback_enabled = true} -daemon.send_test() +daemon.send() check("feedback after start") daemon.stop() feedback_reset() -daemon.send_test() +daemon.send() test:ok(feedback_count == 0, "no feedback after stop") daemon.start() -daemon.send_test() +daemon.send() check("feedback after start") -daemon.send_test() -check("feedback after feedback send_test") +daemon.send() +check("feedback after feedback send") daemon.stop() @@ -136,7 +136,7 @@ server:close() -- check it does not fail without server daemon = box.internal.feedback_daemon daemon.start() -daemon.send_test() +daemon.send() daemon.stop() -- -- 2.24.3 (Apple Git-128)